Closed
Conversation
nurmerey
requested changes
Oct 3, 2020
Contributor
nurmerey
left a comment
nurmerey
left a comment
There was a problem hiding this comment.
Thank you for your contribution @ShiviBhatt. Looks good so far! Let's make sure to remove changes unnecessary for this PR, see comments for more instructions.
Also, can you please add to the PR description how did you test this code?
package.json
Outdated
| "url": "^0.11.0", | ||
| "virtualenv": "0.3.1" | ||
| "virtualenv": "0.3.1", | ||
| "yarn": "^1.22.5" |
Contributor
There was a problem hiding this comment.
It looks like these are your local changes from installation. Is that right? I don't think we need these changes for the purpose of this PR. If this is true, please remove changes from both packages.json and yarn.lock files.
Author
There was a problem hiding this comment.
Hi Rey,
yes, we don't need packages.json and yarn lock changes, shall I create another request?
with only required changes?
ShiviBhatt
force-pushed
the
job-title-position
branch
from
7e780ce to
beeb5ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created Table in schema.sql and Added API in github auth file