Looking For multiselect dropdown#151
Merged
nurmerey merged 6 commits intocoding-allies:masterfrom Oct 28, 2020
Merged
Conversation
nurmerey
requested changes
Oct 2, 2020
Contributor
nurmerey
left a comment
nurmerey
left a comment
There was a problem hiding this comment.
Asked for a few minor changes! Otherwise LGTM 🙌 ! Thank you @nadyafebi
Contributor
Author
|
@nurmerey I changed the stuff you mentioned 😄 |
nurmerey
requested changes
Oct 7, 2020
Contributor
nurmerey
left a comment
nurmerey
left a comment
There was a problem hiding this comment.
One more ask, to remove yarn.lock file. Thank you!
Contributor
Author
|
@nurmerey Removed the yarn.lock (not sure how it got committed there) and also resolved some merge conflict 😃 |
Contributor
Author
Contributor
nurmerey
approved these changes
Oct 28, 2020
Contributor
nurmerey
left a comment
nurmerey
left a comment
There was a problem hiding this comment.
LGTM 💐 Thank you for great work!
This was referenced Oct 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the Looking For field of the Project Form to use Creatable from
react-select. Closes #100.Changes
react-selectas dependency.Creatablecomponent.handleCreatableChangeto help handle changes fromCreatablecomponent.validateFormfunction to handlenullvalue.handleSubmitfunction to format the field value from array to comma-separated string.Demo