#147: add a web redirector service #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update has introduced a FileUniqueId support, that's required to properly handle the photos of different sizes.
Member
Author
|
One problem I am still struggling with is figuring out the For now, it seems Telegram sends us several different |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #147.
It turns out we were writing our database in a wrong way. When I send a photo, Telegram will usually send to bot a message with several
PhotoSizeobjects of different sizes. All of them were written to the database, which I don't think is required.Instead, we should deduplicate thePhotoSizeobjects based on theFileUniqueId, but there's another problem: Funogram version we use doesn't provide the access to this field at all.So, I had to update Funogram and change quite a lot of code in our tests to make it work.The above isn't true and
FileUniqueIdturned out to not be useful for this use case. Anyway, I've decided to update Funogram.TODO: