Skip to content

Telegram content proxy #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ForNeVeR merged 23 commits into from
Aug 28, 2022
Merged

Telegram content proxy #163

ForNeVeR merged 23 commits into from
Aug 28, 2022

Conversation

@ForNeVeR
Copy link
Member

@ForNeVeR ForNeVeR commented Aug 7, 2022 •
edited
Loading

Closes #102. I've decided we need no statistics aside from logs.

TODO:

  • implement the file cache
  • cache cleanup: ensure there's a sanity check (to not accidentally clean up an unrelated directory)
  • squash WIP commits
  • don't forget file cache tests!
  • make sure Emulsion works in the old way (t.me proxies) with the file cache disabled
  • tests for all the branches in the FileCache
  • tests for all the branches in the ContentController
  • make all the tests green
  • make sure there are no TODO remaining
  • content types
  • file names for download
  • manual testing
  • CI: investigate the test failures on Windows
  • deployment instructions, Docker upgrade
  • review everything

@ForNeVeR ForNeVeR self-assigned this Aug 7, 2022
@ForNeVeR ForNeVeR force-pushed the feature/102.content-proxy branch from 0e2be47 to 4c9895f Compare August 21, 2022 19:44
@ForNeVeR ForNeVeR force-pushed the feature/102.content-proxy branch from 4c9895f to 4d6bfc5 Compare August 21, 2022 19:49
gsomix
gsomix reviewed Aug 22, 2022
View reviewed changes
Emulsion.ContentProxy/FileCache.fs
}

let rec processLoop(processor: MailboxProcessor<_ * AsyncReplyChannel<_>>) = async {
while true do
Copy link
Contributor

@gsomix gsomix Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably leak.

Copy link
Member Author

@ForNeVeR ForNeVeR Aug 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have several places with while true in async code already, and they seem non-problematic for now. I think I'll leave that as-is, but will keep an eye on it.

@ForNeVeR ForNeVeR force-pushed the feature/102.content-proxy branch from 27d0db9 to 3977248 Compare August 28, 2022 13:10
@ForNeVeR ForNeVeR force-pushed the feature/102.content-proxy branch from 6952a9f to 2a3c54d Compare August 28, 2022 13:32
@ForNeVeR ForNeVeR force-pushed the feature/102.content-proxy branch from 2a3c54d to f6bcfff Compare August 28, 2022 13:44
@ForNeVeR ForNeVeR marked this pull request as ready for review August 28, 2022 13:45
@ForNeVeR ForNeVeR force-pushed the feature/102.content-proxy branch from f6bcfff to 2861ee8 Compare August 28, 2022 13:46
@ForNeVeR ForNeVeR force-pushed the feature/102.content-proxy branch from 1735749 to 7936682 Compare August 28, 2022 13:56
@ForNeVeR ForNeVeR merged commit 7936682 into master Aug 28, 2022
@ForNeVeR ForNeVeR deleted the feature/102.content-proxy branch August 28, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gsomix gsomix gsomix left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ForNeVeR ForNeVeR

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Telegram content proxy

3 participants

@ForNeVeR @gsomix