Add g:lexima_close_pum_with_escape option#160
Open
mmrwoods wants to merge 1 commit into
Open
Conversation
Similar to the option to allow `<CR>` to accept completions when the popup menu is open, this allows `<Esc>` to be used to close it. This seems worth adding as an option as Lexima adds both `<CR>` and `<Esc>` mappings by default, but currently only allows easy configuration for using `<CR>` with the popup menu. Adding a custom `<Esc>` mapping that is compatible with Lexima is a little tricky, config is so much simpler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the option to allow
<CR>to accept completions when the popup menu is open, this allows<Esc>to be used to close it. This seems worth adding as an option as Lexima adds both<CR>and<Esc>mappings by default, but currently only allows easy configuration for using<CR>with the popup menu. Adding a custom<Esc>mapping that is compatible with Lexima is a little tricky, config is so much simpler.Note: I have not allowed for Vim <= 703 in this change as it's not so outdated it doesn't seem necessary