fix dataset list key error #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderland
reviewed
Aug 15, 2023
cohere/client.py
Outdated
| Dataset.from_dict({"meta": response.get("meta"), **r}, wait_fn=self.wait_for_dataset) | ||
| for r in response["datasets"] | ||
| ] | ||
| if "datasets" in response |
Contributor
There was a problem hiding this comment.
I would use for r in response.get('datasets',[]) or for r in (response.get('datasets') or []) but that's just a suggestion
sanderland
approved these changes
Aug 15, 2023
harry-cohere
approved these changes
Aug 15, 2023
harry-cohere
approved these changes
Aug 15, 2023
lfayoux
force-pushed
the
fix-dataset-list
branch
from
fa361b2 to
39bc2dd
Compare
lfayoux
force-pushed
the
fix-dataset-list
branch
from
39bc2dd to
e205bd1
Compare
fede-kamel
pushed a commit
to fede-kamel/cohere-python
that referenced
this pull request
Jan 26, 2026
* fix dataset list key error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.