Skip to content

Streaming Chat Test: Check if text is not none #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BeatrixCohere merged 1 commit into from
Aug 21, 2023
Merged

Streaming Chat Test: Check if text is not none #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/async/test_async_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,13 @@ async def test_async_chat_stream(async_client):
expected_index = 0
expected_text = ""
async for token in res:
assert isinstance(token.text, str)
assert len(token.text) > 0
assert token.index == expected_index
if token.text:
assert isinstance(token.text, str)
assert len(token.text) > 0
assert token.index == expected_index

expected_text += token.text
expected_index += 1
expected_text += token.text

assert res.texts == [expected_text]
assert res.conversation_id is not None
Expand Down
11 changes: 6 additions & 5 deletions tests/sync/test_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,14 @@ def test_stream(self):
expected_index = 0
expected_text = ""
for token in prediction:
self.assertIsInstance(token.text, str)
self.assertGreater(len(token.text), 0)
if token.text:
self.assertIsInstance(token.text, str)
self.assertGreater(len(token.text), 0)

self.assertIsInstance(token.index, int)
self.assertEqual(token.index, expected_index)
self.assertIsInstance(token.index, int)
self.assertEqual(token.index, expected_index)

expected_text += token.text
expected_text += token.text
expected_index += 1

self.assertEqual(prediction.texts, [expected_text])
Expand Down