Skip to content

Remove generate finish reason assertion in test #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daulet merged 2 commits into from
Oct 4, 2023
Merged

Remove generate finish reason assertion in test #321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d3e442
Update generate finish reason in test
abdullahkady Oct 4, 2023
f510cae
remove finish reason check from sdk
abdullahkady Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/async/test_async_generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,8 @@ async def test_async_generate_stream(async_client):
final_text += token.text

assert res.id != None
assert res.finish_reason, "COMPLETE"

assert isinstance(res.generations, Generations)
assert res.generations[0].finish_reason == "COMPLETE"
assert res.generations[0].prompt == "Hey!"
assert res.generations[0].text == final_text
assert res.generations[0].id != None
Expand Down