Ensure we have enough data to semi-reliably identify regressions #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
reviewed
Aug 16, 2022
Contributor
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @ian-r-rose! It's not totally clear to me how this relates to #249. This appears to be about having enough previous runs to compare to. Is decreased memory usage / wall time still treated as a regression, or am I missing something?
Contributor
Author
I believe that it is not treated as a regression (that is to say, it's correct right now). The issue here was just that there was not enough history in the timeseries to actually make a decent measure of a regression. |
jrbourbeau
approved these changes
Aug 16, 2022
Contributor
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Let's give it a try then 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249