Add arrow_options to read_gbq #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oops let me re-push to my fork and re-open |
Contributor
|
I think repo secrets are used here in CI, so PRing from a branch and not a fork is the right way to go 👍 |
Contributor
Author
|
oh heh. well neither one is working right now, I thought maybe the error I was seeing was bc I didn't have the right permissions to create CI jobs on this repo but it seems to be something else.... |
Merged
Contributor
Author
|
@j-bennet @jrbourbeau CI is happy now post-#48 if you would like to take a look 🙂 |
j-bennet
reviewed
May 8, 2023
dask_bigquery/core.py
Outdated
| read_kwargs: dict | ||
| kwargs to pass to read_rows() | ||
| arrow_options: dict | ||
| kwargs to pass to record_batch.to_pandas() when converting from pyarrow to pandas |
Contributor
There was a problem hiding this comment.
Maybe add a link to https://arrow.apache.org/docs/python/generated/pyarrow.RecordBatch.html#pyarrow.RecordBatch.to_pandas, so people can easily look up those kwargs.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45.
Followed the same pattern pointed out by @j-bennet here.