Skip to content

fix: format erc20 balance #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
0xRAG merged 1 commit into from
Feb 24, 2025
Merged

fix: format erc20 balance #458

0xRAG merged 1 commit into from
Feb 24, 2025

Conversation

@0xRAG
Copy link
Contributor

@0xRAG 0xRAG commented Feb 24, 2025 •
edited
Loading

What changed?

  • Documentation
  • Bug fix
  • New Action
  • New Action Provider
  • Other

Why was this change implemented?

We were not formatting erc20 balances.

Checklist

  • Changelog updated
  • Commits are signed. See instructions
  • Doc strings
  • Readme updates
  • Rebased against master
  • Relevant exports added

How has it been tested?

  • Agent tested
  • Unit tests
Prompt: get USDC balance (address is 0x036CbD53842c5426634e7929541eC2318f3dCF7e)

-------------------
Balance of 0x036CbD53842c5426634e7929541eC2318f3dCF7e is 1
-------------------
The USDC balance for the address 0x036CbD53842c5426634e7929541eC2318f3dCF7e is 1 USDC.
-------------------

Notes to reviewers

@0xRAG 0xRAG requested a review from murrlincoln as a code owner February 24, 2025 20:05
@cb-heimdall
Copy link

cb-heimdall commented Feb 24, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions github-actions bot added documentation Improvements or additions to documentation action provider New action provider wallet provider New wallet provider typescript needs triage labels Feb 24, 2025
CarsonRoscoe
CarsonRoscoe approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@CarsonRoscoe CarsonRoscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xRAG 0xRAG merged commit f0f7b05 into main Feb 24, 2025
14 checks passed
@0xRAG 0xRAG deleted the chore/fix-erc20 branch February 24, 2025 20:30
kylexqian pushed a commit to OpenGradient/agentkit that referenced this pull request Feb 25, 2025
@0xRAG @kylexqian
fix: format erc20 balance (coinbase#458)
2a3d7ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarsonRoscoe CarsonRoscoe CarsonRoscoe approved these changes

@murrlincoln murrlincoln Awaiting requested review from murrlincoln murrlincoln is a code owner

@stat stat Awaiting requested review from stat

@John-peterson-coinbase John-peterson-coinbase Awaiting requested review from John-peterson-coinbase

Assignees

No one assigned

Labels

action provider New action provider documentation Improvements or additions to documentation typescript wallet provider New wallet provider

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xRAG @cb-heimdall @CarsonRoscoe