Skip to content

fix(docs/python): Fix wrong Network import #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
John-peterson-coinbase merged 1 commit into from
Feb 25, 2025
Merged

fix(docs/python): Fix wrong Network import #464

John-peterson-coinbase merged 1 commit into from
Feb 25, 2025

Conversation

@RezaRahemtola
Copy link
Contributor

@RezaRahemtola RezaRahemtola commented Feb 24, 2025

What changed?

  • Documentation
  • Bug fix
  • New Action
  • New Action Provider
  • Other

Why was this change implemented?

Spotted during ETH Denver, the Network import wasn't working

Network support

  • All EVM
  • Base
  • Base Sepolia
  • Other

Wallet support

  • CDP Wallet
  • EVM Wallet
  • Other

Checklist

  • Changelog updated
  • Commits are signed. See instructions
  • Doc strings
  • Readme updates
  • Rebased against master
  • Relevant exports added

How has it been tested?

  • Agent tested
  • Unit tests

Notes to reviewers

@cb-heimdall
Copy link

cb-heimdall commented Feb 24, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions github-actions bot added documentation Improvements or additions to documentation needs triage labels Feb 24, 2025
@RezaRahemtola RezaRahemtola changed the title fix(agentkit/python): Fix wrong Network import fix(python): Fix wrong Network import Feb 24, 2025
@RezaRahemtola RezaRahemtola changed the title fix(python): Fix wrong Network import fix(docs/python): Fix wrong Network import Feb 24, 2025
@John-peterson-coinbase John-peterson-coinbase merged commit d4ac734 into coinbase:main Feb 25, 2025
11 checks passed
@RezaRahemtola RezaRahemtola deleted the patch-1 branch February 25, 2025 06:23
kylexqian pushed a commit to OpenGradient/agentkit that referenced this pull request Feb 25, 2025
@RezaRahemtola @kylexqian
Update README.md (coinbase#464)
05a1a0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@John-peterson-coinbase John-peterson-coinbase John-peterson-coinbase approved these changes

@murrlincoln murrlincoln Awaiting requested review from murrlincoln murrlincoln is a code owner

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RezaRahemtola @cb-heimdall @John-peterson-coinbase