Skip to content

fix: format erc20 balance #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
0xRAG merged 1 commit into from
Feb 25, 2025
Merged

fix: format erc20 balance #467

0xRAG merged 1 commit into from
Feb 25, 2025

Conversation

@0xRAG
Copy link
Contributor

@0xRAG 0xRAG commented Feb 25, 2025 •
edited
Loading

What changed?

  • Documentation
  • Bug fix
  • New Action
  • New Action Provider
  • Other

Why was this change implemented?

We were not formatting erc20 balances.

Checklist

  • Changelog updated
  • Commits are signed. See instructions
  • Doc strings
  • Readme updates
  • Rebased against master
  • Relevant exports added

How has it been tested?

  • Agent tested
  • Unit tests

Setup: Fauceted 1 USDC.

Before

Prompt: print USDC balance (token address: 0x036CbD53842c5426634e7929541eC2318f3dCF7e)

-------------------
Balance of 0x036CbD53842c5426634e7929541eC2318f3dCF7e is 1000000
-------------------
The USDC balance for the token address `0x036CbD53842c5426634e7929541eC2318f3dCF7e` is 1,000,000.
-------------------

After

Prompt: print USDC balance (address is 0x036CbD53842c5426634e7929541eC2318f3dCF7e)

-------------------
Balance of 0x036CbD53842c5426634e7929541eC2318f3dCF7e is 1
-------------------
The USDC balance for the address 0x036CbD53842c5426634e7929541eC2318f3dCF7e is 1 USDC.
-------------------

@0xRAG 0xRAG requested a review from murrlincoln as a code owner February 25, 2025 18:15
@cb-heimdall
Copy link

cb-heimdall commented Feb 25, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions github-actions bot added wallet provider New wallet provider needs triage labels Feb 25, 2025
@github-actions github-actions bot removed the wallet provider New wallet provider label Feb 25, 2025
CarsonRoscoe
CarsonRoscoe reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@CarsonRoscoe CarsonRoscoe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: changelog should be updated
e.g. https://github.com/coinbase/agentkit/pull/458/files#diff-f62d2e4ed61334b52872fcbb5cd836c8e3d0d4c6c2e0e82eac7bade1fbeb4674R7

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 25, 2025
CarsonRoscoe
CarsonRoscoe approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@CarsonRoscoe CarsonRoscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xRAG 0xRAG merged commit 008f871 into main Feb 25, 2025
14 checks passed
@0xRAG 0xRAG deleted the AGENT-224 branch February 25, 2025 18:56
kylexqian pushed a commit to OpenGradient/agentkit that referenced this pull request Feb 25, 2025
@0xRAG @kylexqian
fix: format erc20 balance (coinbase#467)
e34b5c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarsonRoscoe CarsonRoscoe CarsonRoscoe approved these changes

@murrlincoln murrlincoln Awaiting requested review from murrlincoln murrlincoln is a code owner

@stat stat Awaiting requested review from stat

@John-peterson-coinbase John-peterson-coinbase Awaiting requested review from John-peterson-coinbase

Assignees

No one assigned

Labels

action provider New action provider documentation Improvements or additions to documentation python

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xRAG @cb-heimdall @CarsonRoscoe