-
Notifications
You must be signed in to change notification settings - Fork 590
feat:post embeds on Farcaster and media on Twitter (ts) #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Heimdall Review Status
|
| async postTweet(args: z.infer<typeof TwitterPostTweetSchema>): Promise<string> { | ||
| try { | ||
| const response = await this.client.v2.tweet(args.tweet); | ||
| let mediaOptions = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest updating the action's descriptions to mention the newly added mediaIds and how the agent should use them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, done!
CarsonRoscoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @phdargen, this PR is looking good and I'm happy to get this in :)
Can you rebase against main first and address my one comment?
Then I'll do some testing and aim to get this in for this weeks release
9023d28 to
770df82
Compare
|
@CarsonRoscoe Rebased again bc of some changes to the twitter provider yesterday. After rebasing I cant run the chatbots examples anymore. pnpm i && pnpm build and pnpm test work fine but getting the error below for the chatbot. I get the same error for a clean master checkout, so I don't think this is related to my PR. I suspect this might come from #678 that seems to do some hacks for "jose" in framework-extensions (eg https://github.com/coinbase/agentkit/blob/bc4e7be8a3ab0cc0c576b642b000bf71df0c06dd/typescript/framework-extensions/langchain/setup-jest.js), but not in chatbot. |
|
Rebased and tested again, see recent posts above. Should be good to go @CarsonRoscoe |
BTW, this error occurs when running with node v20. I think all the CDP v2 stuff requires v22, while all the READMEs still have node v18 as prerequisite |
CarsonRoscoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the contribution
Description
Added media upload support for Twitter and embeds support for Farcaster
Tests
Cast: https://farcaster.xyz/truecastagent/0x4f24e69e
Posts:
Checklist
A couple of things to include in your PR for completeness: