-
Notifications
You must be signed in to change notification settings - Fork 591
Zora Coins SDK #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zora Coins SDK #704
Conversation
✅ Heimdall Review Status
|
CarsonRoscoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @phdargen!
Code looks reasonable, and checking out the branch, it seems to work. I am willing to merge once you rebase against main,
Thank you for another contribution :)
|
Hi @CarsonRoscoe, thanks for checking. Actually Zora just upgraded their contracts and sdk to v4, so the code should be updated. Will let you know when I get to it. |
CarsonRoscoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the insight. Please ping me once you get it in, and thanks again for the contribution
veyetex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
|
Hi @CarsonRoscoe, updated to sdk v4 and tested with hosted and local image (see above). |
Description
Implements Zora Coins SDK integration
Tests
Coin on Zora: https://zora.co/coin/base:0x0c66a731f293d7bd024dc6d0b99c403019cc3972
Coin on Zora: https://zora.co/coin/base:0x11A87759B9B7eC12a4c29EA8f675291b464aD12a
Checklist
A couple of things to include in your PR for completeness: