Conversation
✅ Heimdall Review Status
|
Contributor
|
Hi @ya7ya, thanks for your contribution!
|
phdargen
reviewed
Jul 23, 2025
| ## Actions | ||
|
|
||
| - `wrap_eth`: Convert ETH to WETH | ||
| - `unwrap-eth`: Convert WETH to ETH |
Contributor
There was a problem hiding this comment.
nit: should be unwrap_eth
phdargen
reviewed
Jul 23, 2025
| - The amount is a string and cannot have any decimal points, since the unit of measurement is wei. | ||
| - Make sure to use the exact amount provided, and if there's any doubt, check by getting more information before continuing with the action. | ||
| - 1 wei = 0.000000000000000001 WETH | ||
| - Minimum unwrap amount is 100000000000000 wei (0.0000001 WETH) |
Contributor
There was a problem hiding this comment.
this is wrong, should be 100000000000 wei (0.0000001 WETH)
please also fix for wrap action
Contributor
|
Looks good and I tested it successfully @CarsonRoscoe |
CarsonRoscoe
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a new action (unwrap) to the WETH agent actions
Tests
example prompt
Checklist
A couple of things to include in your PR for completeness: