Merged
Conversation
hcopp
reviewed
Feb 17, 2026
hcopp
reviewed
Feb 17, 2026
packages/web/src/buttons/Button.tsx
Outdated
| paddingInline: | ||
| typeof paddingX === 'number' ? theme.space[paddingX] - borderWidthValue : undefined, | ||
| }; | ||
| }, [borderWidth, theme.borderWidth, theme.space, paddingX, paddingY, style]); |
Contributor
There was a problem hiding this comment.
Same thing as above, I could also see someone randomly wanting to set different padding for left and right sides, depending on if they have icons.
Contributor
Author
There was a problem hiding this comment.
@hcopp these padding values come from the props so they are already ready to be customized. They will just get offset slightly to account for the border, unless you think we should only do that if they DONT provide padding props?
cb-ekuersch
commented
Feb 18, 2026
cb-ekuersch
commented
Feb 18, 2026
cb-ekuersch
commented
Feb 18, 2026
cb-ekuersch
commented
Feb 18, 2026
cb-ekuersch
commented
Feb 18, 2026
cb-ekuersch
commented
Feb 18, 2026
cb-ekuersch
force-pushed
the
remove-height
branch
4 times, most recently
from
31d958f to
6c24b40
Compare
cb-ekuersch
changed the title
cb-ekuersch
force-pushed
the
remove-height
branch
2 times, most recently
from
6e13e2b to
fbb72e9
Compare
hcopp
reviewed
Feb 20, 2026
hcopp
reviewed
Feb 20, 2026
| import { animationConfig, DefaultSlideButtonHandle } from './DefaultSlideButtonHandle'; | ||
|
|
||
| export const slideButtonTestID = 'slide-button'; | ||
| // |
Contributor
There was a problem hiding this comment.
nit: could we just add a small description here? Maybe
We are still using a harcoded height for SlideButton due to the background height being arbitrary.
Contributor
Author
There was a problem hiding this comment.
will do before i merge!
hcopp
previously approved these changes
Feb 20, 2026
haoruikun-cb
previously approved these changes
Feb 20, 2026
Contributor
maximo-macchi-cb
left a comment
maximo-macchi-cb
left a comment
There was a problem hiding this comment.
Thanks for the huge effort on this. Great improvement to see coming soon! My comments apply for both web and mobile.
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
1 similar comment
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
cb-ekuersch
force-pushed
the
remove-height
branch
from
58e6ea9 to
731bb1d
Compare
…nents to use content-based sizing instead of predetermined height
cb-ekuersch
force-pushed
the
remove-height
branch
from
731bb1d to
afc8825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Removes constant: interactableHeight and updates all usage sites. Components using this constant have now been refactored so that their content dictates their final height.
Removes other instances of hard-coded dimensions (e.g. min-height, border-width) and replaces them with theme vars or eliminates them entirely if the design spec was achievable with content-driven layout/spacing.
In some cases where a value could not be removed (DotCount height), care was taken to ensure the value is at least overridable via props.
Linear:
Root cause (required for bugfixes)
UI changes
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false