Skip to content

Harryhao/cds 1268 shorten interactable css variables#410

Merged
haoruikun-cb merged 2 commits intocds-v9from
harryhao/cds-1268-shorten-interactable-css-variables
Feb 20, 2026
Merged

Harryhao/cds 1268 shorten interactable css variables#410
haoruikun-cb merged 2 commits intocds-v9from
harryhao/cds-1268-shorten-interactable-css-variables

Conversation

@haoruikun-cb
Copy link
Copy Markdown
Contributor

What changed? Why?

Shorten Pressable CSS variables according to this doc: https://docs.google.com/document/d/1C5tvEKKGsSkTgdF_pzPShBiOhfYZTNIc9ucYlPUrEeQ/edit?tab=t.0

Root cause (required for bugfixes)

UI changes

iOS Old iOS New
old screenshot new screenshot
Android Old Android New
old screenshot new screenshot
Web Old Web New
old screenshot new screenshot

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@linear
Copy link
Copy Markdown

linear bot commented Feb 18, 2026

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Feb 18, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS 🟡 See below

🟡 CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 🟡 0/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@haoruikun-cb haoruikun-cb force-pushed the harryhao/cds-1268-shorten-interactable-css-variables branch 2 times, most recently from 30c9662 to d6082b5 Compare February 18, 2026 23:20
@haoruikun-cb haoruikun-cb changed the base branch from master to v9-migrator February 18, 2026 23:20
@haoruikun-cb haoruikun-cb changed the base branch from v9-migrator to cds-v9 February 18, 2026 23:20
@haoruikun-cb haoruikun-cb force-pushed the harryhao/cds-1268-shorten-interactable-css-variables branch from 4d139a6 to 4d9f738 Compare February 20, 2026 19:39
haoruikun-cb and others added 2 commits February 20, 2026 13:54
Co-authored-by: Cursor <cursoragent@cursor.com>
@haoruikun-cb haoruikun-cb force-pushed the harryhao/cds-1268-shorten-interactable-css-variables branch from 4d9f738 to d123ac3 Compare February 20, 2026 19:54
@haoruikun-cb haoruikun-cb merged commit 8c2c1da into cds-v9 Feb 20, 2026
14 of 15 checks passed
@haoruikun-cb haoruikun-cb deleted the harryhao/cds-1268-shorten-interactable-css-variables branch February 20, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment