Conversation
haoruikun-cb
approved these changes
Feb 23, 2026
| <HStack alignItems="center" justifyContent={title ? 'space-between' : 'flex-end'}> | ||
| {typeof title === 'string' ? ( | ||
| <Text font="title3" style={styles?.title}> | ||
| <Text flexShrink={1} font="title3" numberOfLines={1} style={styles?.title}> |
Contributor
There was a problem hiding this comment.
We have small risk of visual regression of this change. We need to document this in V9 release note/migration guide to make customer aware of this
Contributor
Author
There was a problem hiding this comment.
Thanks for the quick review! Yep I did note this in v9 changes doc so as long as we go line by line on that in the v9 release note we can flag it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
In v9 we want to drop the new pagination variant of Carousel, since we had deprecated the old dot style. There should be limited uses of this and it shouldn't cause any layout shifts so I believe it is safe to do in v9. If we have a migrator tool I can help modify it so users simply drop the prop being passed in.
We also are limiting the title to 1 line by default, to match design. This was considered a breaking change when we realized it in v8.
UI changes
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false