Skip to content

fix: update RemoteImageGroup excess bg color#512

Merged
hcopp merged 4 commits intomasterfrom
hunter/remote-image-group-excess
Mar 17, 2026
Merged

fix: update RemoteImageGroup excess bg color#512
hcopp merged 4 commits intomasterfrom
hunter/remote-image-group-excess

Conversation

@hcopp
Copy link
Copy Markdown
Contributor

@hcopp hcopp commented Mar 17, 2026

What changed? Why?

This PR adjusts our RemoteImageGroup excess item background color to improve contrast.

Root cause (required for bugfixes)

bgOverlay doesn't have enough contrast with bg. This is not an explicit component in design, likely leading to this oversight. Design is looking to add this to design.

UI changes

iOS Old iOS New
Web Old Web New
image image
image image
image image
image image

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Mar 17, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS ✅ See below

CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 1/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@hcopp hcopp marked this pull request as ready for review March 17, 2026 18:07
@hcopp hcopp self-assigned this Mar 17, 2026
@hcopp hcopp requested review from haoruikun-cb and sverg-cb March 17, 2026 18:11
@hcopp hcopp merged commit 63f7999 into master Mar 17, 2026
30 checks passed
@hcopp hcopp deleted the hunter/remote-image-group-excess branch March 17, 2026 18:53
hcopp added a commit that referenced this pull request Mar 17, 2026
* feat: deploy Figma audit HTML report to GitHub Pages on master push (#508)

- Add --html flag to the audit-figma-integration command to generate the HTML report
- Copy the date-stamped report to index.html so it's accessible at the Pages root
- Add job-level permissions (pages: write, id-token: write) for Pages deployment
- Add environment declaration linking the job to the github-pages environment
- Add configure-pages, upload-pages-artifact, and deploy-pages steps
- Allow workflow_dispatch so the audit and Pages deploy can be triggered manually

Resolves CDS-1700

* feat: add freeSolo Combobox example (#498)

* feat: add freeSolo Combobox example

* Add accessibility section

* Fix

* Update country selector

* Update combobox a11y

* chore: update Checkbox borderRadius to match design (#509)

* chore: update Checkbox borderRadius to match design

* Bump version

* Update changelog and exclude a11y test from percy

* Include storybook test add ons when not in visreg

* Update chip docs (#510)

* feat: Publish illustrations 2026-03-17 (#511)

* feat: Publish illustrations 2026-03-17

* Update changelog

* format

* generate icon svg map

* update changelog for ui-mobile-playground

* fix: update RemoteImageGroup excess bg color (#512)

* fix: update RemoteImageGroup excess bg color

* Bump version

* Disable carousel targetSize a11y flag

---------

Co-authored-by: Erich <137924413+cb-ekuersch@users.noreply.github.com>
Co-authored-by: adrienzheng-cb <adrien.zheng@coinbase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants