Skip to content

fix: tab navigation deprecation#548

Merged
haoruikun-cb merged 1 commit intocds-v9from
harry/tabnavigation-deprecation
Mar 25, 2026
Merged

fix: tab navigation deprecation#548
haoruikun-cb merged 1 commit intocds-v9from
harry/tabnavigation-deprecation

Conversation

@haoruikun-cb
Copy link
Copy Markdown
Contributor

What changed? Why?

The deprecation notice should be applied to the exported variable. Otherwise it's not marking in the IDE.

Root cause (required for bugfixes)

UI changes

iOS Old iOS New
old screenshot new screenshot
Android Old Android New
old screenshot new screenshot
Web Old Web New
old screenshot new screenshot

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@haoruikun-cb haoruikun-cb marked this pull request as ready for review March 25, 2026 20:50
@haoruikun-cb haoruikun-cb merged commit 5d19725 into cds-v9 Mar 25, 2026
17 checks passed
@haoruikun-cb haoruikun-cb deleted the harry/tabnavigation-deprecation branch March 25, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants