feat: add DefaultTab and DefaultTabsActiveIndicator.#558
Merged
adrienzheng-cb merged 2 commits intomasterfrom Apr 2, 2026
Merged
feat: add DefaultTab and DefaultTabsActiveIndicator.#558adrienzheng-cb merged 2 commits intomasterfrom
adrienzheng-cb merged 2 commits intomasterfrom
Conversation
Collaborator
✅ Heimdall Review Status
✅
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
✅
1/1
|
Denominator calculation
|
Contributor
2eaa48a to
7db3e7e
Compare
62df50c to
2ae239e
Compare
hcopp
reviewed
Mar 31, 2026
Contributor
|
@adrienzheng-cb can you provide some screenshots and explain the purpose behind this? If I'm reading correctly, since we deprecated TabNavigation we are providing a default TabComponent for Tabs right? And then also we are deprecating TabLabel and TabIndicator which are used for TabNavigation and don't seem to be usable with Tabs out of the box so we needed to make DefaultTab to replace TabLabel and DefaultTabsActiveIndicator to replace TabIndicator. One last thing, if you can explain the shift from |
c8c2fc6 to
13d30b1
Compare
hcopp
reviewed
Apr 1, 2026
cd7ff34 to
3252e60
Compare
hcopp
reviewed
Apr 1, 2026
hcopp
reviewed
Apr 1, 2026
adrienzheng-cb
commented
Apr 1, 2026
hcopp
reviewed
Apr 1, 2026
8ffc6d2 to
df264c2
Compare
df264c2 to
32bf270
Compare
1. Added default sub-components to Tabs to replace TabNavigation. 2. Made indvidual Tab's prop extensible. 3. Deprecated TabIndicator and TabLabel
32bf270 to
b454c7e
Compare
hcopp
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Summary
Adds
DefaultTabandDefaultTabsActiveIndicatorsoTabscan be used out of the box for the common label + animated underline pattern, documents it on the docs site, and steers consumers away fromTabNavigationvia type-level deprecation.Changes
@coinbase/cds-commonuseTabs: Optional second genericTTab extends TabValue<TabId>sotabs,activeTab, andonChangecan reflect custom tab row types (defaults match previous behavior).@coinbase/cds-web(packages/web/src/tabs)DefaultTab: Default tab control (label styling, optionalcount/max, focus ring).DefaultTabsActiveIndicator: Default underline indicator aligned with the tab row.Tabs:TabComponentdefaults toDefaultTab; genericTabComponentProps/TabsProps; internal wiring foruseTabswithTTab.TabNavigation:@deprecatedon exported types (TabProps,CustomTabProps,TabNavigationBaseProps,TabNavigationProps) — useTabsinstead.TabLabel/TabIndicator: Deprecation-related doc tweaks.__stories__/Tabs.stories.tsx: Storybook coverage for default and advanced cases.index.ts: ExportsDefaultTabandDefaultTabsActiveIndicator.@coinbase/cds-mobile(packages/mobile/src/tabs)DefaultTab,DefaultTabsActiveIndicator, andTabsupdates (defaultTabComponent,handleTabsChangeforonChangetyping).TabNavigation: Same type deprecations as web.__stories__/Tabs.stories.tsx: FullExampleScreenstories (replaces TabNavigation-only placeholder).Docs (
apps/docs)Tabs: Examples prioritizeDefaultTabsActiveIndicatorand defaultTabComponent; separate section for custom tab + indicator._webStyles.mdx: Styles explorer uses the default tab + indicator path.Migration
Tabs+DefaultTab+DefaultTabsActiveIndicatorfor the underline tab list.TabNavigationtypes are deprecated; plan to move call sites toTabsbefore removal (see@deprecationExpectedRemovalon types).UI changes
Screen.Recording.2026-03-30.at.2.04.56.PM.mov
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2026-03-30.at.14.06.24.mov
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false