Conversation
Collaborator
✅ Heimdall Review Status
✅
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
✅
1/1
|
Denominator calculation
|
cb-ekuersch
approved these changes
Mar 30, 2026
hcopp
commented
Mar 30, 2026
|
|
||
| #### 📘 Misc | ||
|
|
||
| - Chore: deprecate CardGroup. [[#560](https://github.com/coinbase/cds/pull/560)] |
Contributor
Author
There was a problem hiding this comment.
Figured this didn't need to be a separate version but needs to be in changelog!
Contributor
adrienzheng-cb
added a commit
that referenced
this pull request
Mar 30, 2026
* feat: add indeterminate ProgressCircle (#501) * feat: add indeterminate ProgressCircle, unify progress size and float-label math - Add indeterminate prop to ProgressCircle (web & mobile): spinning state with configurable weight, default stroke ratio 0.11; animate full SVG on mobile, CSS keyframes on web; hide default content when indeterminate. - Add getProgressSize(weight) in common and deprecate useProgressSize; use getProgressSize in ProgressBar and ProgressCircle on both platforms. - Simplify ProgressBarWithFloatLabel (web & mobile): remove usePreviousValues, useIsoEffect, and imperative animation; use shared getEndTranslateX so float label trailing edge follows fill end (containerWidth * progress - textWidth); web uses useMotionProps + MotionBox, mobile animates translateX to target. - ProgressBar/ProgressCircle: progress optional with default 0; add originX/ originY in getProgressCircleParams; web ProgressCircle uses pathLength=1. - Deprecate Spinner (web & mobile) in favor of indeterminate ProgressCircle. - ProgressBar tests: update float-label position expectation (80) and accept transform none/translateX(0) for zero progress; iconSvgMap regenerated. * update test and deprecation message * add more button stories * a11y fix * remove 0.11 * add progressCircleSize prop * update changelogs and package versions * add progressCircleSize prop to IconButton * fix removal version * chore: deprecate CardGroup (#560) * chore: deprecate CardGroup * Update changelog * feat: added cds skills for distribution (#561) * chore: deprecate old card (#562) * chore: deprecate old card 1. derpecated Card and related components and types 2. added derepcate-cds-api-skill * update changelogs * tweaks --------- Co-authored-by: Hunter Copp <huntercolecopp@gmail.com> Co-authored-by: Harry <ruikun.hao@coinbase.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR deprecates CardGroup, which is based on our already deprecated Group. There is no doc page for this component.
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false