feat: [CDS-1575] Add type focus to <Select>#571
Merged
maximo-macchi-cb merged 8 commits intomasterfrom Apr 2, 2026
Merged
Conversation
Collaborator
✅ Heimdall Review Status
✅
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
✅
1/1
|
Denominator calculation
|
maximo-macchi-cb
had a problem deploying
to
production
GitHub Actions
Error
maximo-macchi-cb
had a problem deploying
to
production
GitHub Actions
Error
maximo-macchi-cb
force-pushed
the
max/select-type-focus
branch
from
25a2855 to
b60f9ec
Compare
maximo-macchi-cb
temporarily deployed
to
production
GitHub Actions
Inactive
cb-ekuersch
previously approved these changes
Mar 31, 2026
Contributor
cb-ekuersch
left a comment
cb-ekuersch
left a comment
There was a problem hiding this comment.
one nit - but looks good!
| }), | ||
| flip: () => ({}), | ||
| })); | ||
| jest.mock('@floating-ui/react-dom', () => { |
Contributor
There was a problem hiding this comment.
nit: might be useful to make this a reusable mock in common jest setup
Contributor
|
Fix looks good from a11y perspective. |
maximo-macchi-cb
had a problem deploying
to
production
GitHub Actions
Error
maximo-macchi-cb
temporarily deployed
to
production
GitHub Actions
Inactive
maximo-macchi-cb
force-pushed
the
max/select-type-focus
branch
from
97d0220 to
d987804
Compare
maximo-macchi-cb
temporarily deployed
to
production
GitHub Actions
Inactive
cb-ekuersch
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR adds type focus behavior for the
<Select>and<Combobox>components. When a user is focused on the component's trigger, if they type a letter and it matches the first letter of an option in the dropdown, the dropdown will open and auto focus to said option.Root cause (required for bugfixes)
This behavior wasn't included in the original
<Select>so it's not considered a bug.UI changesTesting
How has it been tested?
Testing instructions
You can test this yourself in the
alpha/select/__stories__/Select.stories.tsx. Using your keyboard, focus on the trigger and type the letter "f". Confirm that the "Fig" option is auto focused when the dropdown opens.Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false