Skip to content

feat: Cds skills improvement#574

Merged
haoruikun-cb merged 6 commits intomasterfrom
cds-skills-improvement
Apr 1, 2026
Merged

feat: Cds skills improvement#574
haoruikun-cb merged 6 commits intomasterfrom
cds-skills-improvement

Conversation

@haoruikun-cb
Copy link
Copy Markdown
Contributor

@haoruikun-cb haoruikun-cb commented Apr 1, 2026

What changed? Why?

  1. improved visual verification instructions
  2. provided README for human user
  3. Added instruction and scripts to determine runtime and import path

Root cause (required for bugfixes)

UI changes

iOS Old iOS New
old screenshot new screenshot
Android Old Android New
old screenshot new screenshot
Web Old Web New
old screenshot new screenshot

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

* Update version in cds-code and design-to-code skills to 1.0.1
* Revise visual verification instructions to include asking users for screenshots when inspection tooling is unavailable
@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Apr 1, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS ✅ See below

CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 1/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@haoruikun-cb haoruikun-cb marked this pull request as ready for review April 1, 2026 18:04
cb-ekuersch
cb-ekuersch previously approved these changes Apr 1, 2026
- Updated the discovery script to identify the CDS runtime (web or mobile) based on installed packages.
- Revised documentation to reflect changes in the discovery process, consolidating steps for clarity.
@haoruikun-cb haoruikun-cb merged commit c93ab12 into master Apr 1, 2026
26 of 27 checks passed
@haoruikun-cb haoruikun-cb deleted the cds-skills-improvement branch April 1, 2026 18:55
cb-ekuersch pushed a commit that referenced this pull request Apr 2, 2026
* chore: bump version to 1.0.1 and update visual verification instructions

* Update version in cds-code and design-to-code skills to 1.0.1
* Revise visual verification instructions to include asking users for screenshots when inspection tooling is unavailable

* feat: added readme for human readers

* chore: format

* feat: dynamically determine cds import scope for skill

* fix: exclude v7 packages from CDS import scope determination

* feat: enhance CDS package discovery to include runtime detection

- Updated the discovery script to identify the CDS runtime (web or mobile) based on installed packages.
- Revised documentation to reflect changes in the discovery process, consolidating steps for clarity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants