Skip to content

fix: minor type update#602

Open
adrienzheng-cb wants to merge 2 commits intocds-v9-masterfrom
adrine/tray-render-children
Open

fix: minor type update#602
adrienzheng-cb wants to merge 2 commits intocds-v9-masterfrom
adrine/tray-render-children

Conversation

@adrienzheng-cb
Copy link
Copy Markdown
Contributor

What changed? Why?

Super minor update on type of TrayRenderChildren. Switched from React.ReactElement to React.ReactNode for consistency with other RenderChildren type.

Root cause (required for bugfixes)

UI changes

iOS Old iOS New
old screenshot new screenshot
Android Old Android New
old screenshot new screenshot
Web Old Web New
old screenshot new screenshot

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants