This repository was archived by the owner on Mar 3, 2020. It is now read-only.
Added check on content-type in http error handling#56
Closed
simlay wants to merge 1 commit intocoinbase:masterfrom
Closed
Added check on content-type in http error handling#56simlay wants to merge 1 commit intocoinbase:masterfrom
simlay wants to merge 1 commit intocoinbase:masterfrom
Conversation
Contributor
|
Thanks, this looks great. I'll need to test this as we're lacking test coverage for these tests cases so will merge later |
Author
|
I'm all for writing some tests. My only issue is that the nock http implementation doesn't have the getHeaders on a response object. Though, I could be using it wrong. @jorilallo Do you have any suggestions on this? |
| {name: _convertErrorName(errorBody.id)}); | ||
| } else { | ||
| error = createError(response.statusCode, | ||
| 'InternalServerError'); |
Contributor
There was a problem hiding this comment.
I would prefer still keeping the actual error message here. Return response.body rather than masking it with 'InternalServerError'
Alternatively,
var errorBody;
try {
errorBody = _parseError(JSON.parse(response.body));
} catch (ex) {
errorBody = { id: -1, message: response.body };
}
...
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for #55
I'll be honest, my Node isn't perfect I'm all for a cleaner solution if suggested.