Skip to content

chore: Increase Wallet dropdown SVG sizes to 18x18#1041

Merged
Zizzamia merged 3 commits intomainfrom
paul/increase-img-size
Aug 13, 2024
Merged

chore: Increase Wallet dropdown SVG sizes to 18x18#1041
Zizzamia merged 3 commits intomainfrom
paul/increase-img-size

Conversation

@cpcramer
Copy link

@cpcramer cpcramer commented Aug 13, 2024

What changed? Why?
Increase our wallet logo sizes from 16x16 to 18x18.

Before After
Screenshot 2024-08-12 at 5 06 38 PM Screenshot 2024-08-12 at 5 06 23 PM
**Notes to reviewers**

How has it been tested?

@vercel
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 0:15am

@cpcramer cpcramer changed the title chore: Increase Wallet logo sizes to 18x18 chore: Increase Wallet dropdown SVG sizes to 18x18 Aug 13, 2024
rel={rel}
>
<div className="-translate-y-1/2 absolute top-1/2 left-4 flex h-4 w-4 items-center justify-center">
<div className="-translate-y-1/2 absolute top-1/2 left-4 flex h-[1.125rem] w-[1.125rem] items-center justify-center">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rem? are we sure this is stable? rem usually is relative to the screen.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous setting (h-4 and w-4) are also using REM

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-08-12 at 5 18 41 PM

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-08-12 at 5 19 12 PM

@Zizzamia Zizzamia merged commit 7d03bf3 into main Aug 13, 2024
@Zizzamia Zizzamia deleted the paul/increase-img-size branch August 13, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants