Skip to content

feat: WalletDropdownFundLink QA improvements#1070

Merged
Zizzamia merged 6 commits intomainfrom
alec/remove-popupFeatures
Aug 15, 2024
Merged

feat: WalletDropdownFundLink QA improvements#1070
Zizzamia merged 6 commits intomainfrom
alec/remove-popupFeatures

Conversation

@0xAlec
Copy link
Contributor

@0xAlec 0xAlec commented Aug 15, 2024

What changed? Why?

  • remove popupFeatures prop
  • new icon for WalletDropdownFundLink
  • make popup the default behavior
  • add Wallet to Playground

Notes to reviewers
@mindapivessa icon padding will be fixed in a later PR

How has it been tested?
https://onchainkit-playground-3e6a0cnd2-coinbase-vercel.vercel.app/

@vercel
Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 10:40pm

@vercel
Copy link

vercel bot commented Aug 15, 2024

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this project.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 15, 2024
@0xAlec 0xAlec changed the title Alec/remove popup features feat: WalletDropdownFundLink QA improvements Aug 15, 2024
@0xAlec 0xAlec marked this pull request as ready for review August 15, 2024 22:44
@Zizzamia Zizzamia merged commit 5933b73 into main Aug 15, 2024
@Zizzamia Zizzamia deleted the alec/remove-popupFeatures branch August 15, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Development

Successfully merging this pull request may close these issues.

2 participants