Skip to content

chore: Fix hover state for all components#1092

Merged
Zizzamia merged 6 commits intomainfrom
paul/fix-on-hover-connect-wallet
Aug 18, 2024
Merged

chore: Fix hover state for all components#1092
Zizzamia merged 6 commits intomainfrom
paul/fix-on-hover-connect-wallet

Conversation

@cpcramer
Copy link

@cpcramer cpcramer commented Aug 17, 2024

What changed? Why?
Fix hover state styling for all components and update specific buttons

Issue:

  • Our themed CSS class variables were not correctly applying the custom hover styles.
  • As a result, none of the components were displaying our intended default hover styling.

Fix:

  1. In theme.ts: Corrected how we access the hover state variable.
  2. For TransactionButton and WalletDropdown:
    • Implemented the 'pressable' class.
    • This maintains their current styling while also enabling the use of our defined state classes (including hover).

Outcome:

  • All components now correctly display the default hover styling.
  • TransactionButton and WalletDropdown have consistent styling with added state-based effects.

Watch the video walkthrough to see the tested behavior

Notes to reviewers

How has it been tested?
Confirmed for the Connect Wallet button and Transaction button in light and dark modes.

@vercel
Copy link

vercel bot commented Aug 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2024 10:59pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2024 10:59pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2024 10:59pm

<button
className={cn(
background.primary,
pressable.primary,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, very interesting

@Zizzamia Zizzamia merged commit ebff942 into main Aug 18, 2024
@Zizzamia Zizzamia deleted the paul/fix-on-hover-connect-wallet branch August 18, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants