Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xAlec
changed the title
useSendCall and useSendCallsuseSendCall and useSendCalls
cpcramer
approved these changes
Aug 21, 2024
abcrane123
approved these changes
Aug 21, 2024
Zizzamia
reviewed
Aug 21, 2024
.changeset/dry-actors-bathe.md
Outdated
| "@coinbase/onchainkit": patch | ||
| --- | ||
|
|
||
| **feat**: `useSendCall` and `useSendCalls` by @0xAlec #1130 |
Contributor
There was a problem hiding this comment.
Let's make sure we are a bit more verbose in what those function do.
The goal of a CHANGELOG is to inform and help the developer understand what's going on.
abcrane123
reviewed
Aug 21, 2024
src/transaction/hooks/useSendCall.ts
Outdated
| setLifeCycleStatus, | ||
| transactionHashList, | ||
| }: UseSendCallParams) { | ||
| const { status, sendTransactionAsync, data } = useSendCallWagmi({ |
Contributor
There was a problem hiding this comment.
what are your thoughts on renaming this to be sendCallAsync instead of sendTransactionAsync for readability sake
Contributor
Author
There was a problem hiding this comment.
good call! added the alias
0xAlec
changed the title
useSendCall and useSendCallsuseSendCall and useSendCalls hooks to support call-type transactions in Transaction component
Zizzamia
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
useSendCallanduseSendCallsin the same format asuseWriteContractanduseWriteContractsto support calldata in theTransactioncomponentNotes to reviewers
How has it been tested?
N/A