Skip to content

chore: Refine Wallet UI - Update dropdown, badges, and text.#990

Merged
Zizzamia merged 17 commits intomainfrom
paul/simplify-wallet-dropdown-copy
Aug 7, 2024
Merged

chore: Refine Wallet UI - Update dropdown, badges, and text.#990
Zizzamia merged 17 commits intomainfrom
paul/simplify-wallet-dropdown-copy

Conversation

@cpcramer
Copy link

@cpcramer cpcramer commented Aug 6, 2024

What changed? Why?

  • Remove <Badge /> from Wallet docs as it creates confusion because it is missing the schemaID.
  • Update all Wallet dropdown SVGs to render 16x16.
  • Update text to Claim Basename (if no Basename), otherwise "Profile".
  • Update Wallet dropdown text from Go to Wallet Dashboard to Wallet.
  • Vertically align wallet images
Before After
Screenshot 2024-08-06 at 2 44 52 PM Screenshot 2024-08-06 at 5 12 26 PM
Screenshot 2024-08-06 at 5 12 45 PM

Notes to reviewers

How has it been tested?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 6, 2024
@vercel
Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 1:05am

<Identity className="px-4 pt-3 pb-2" hasCopyAddressOnClick>
<Avatar />
<Name>
<Badge />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is missing here? :)
I let you guess what's missing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm do we want it displayed as <Name />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha sweet, that's the only thing I could think of 😆

@cpcramer cpcramer changed the title docs: Clean up Wallet docs chore: Clean up Wallet docs Aug 6, 2024
@cpcramer cpcramer force-pushed the paul/simplify-wallet-dropdown-copy branch from ba2abfe to 217c0de Compare August 6, 2024 22:39
@cpcramer cpcramer changed the title chore: Clean up Wallet docs chore: Refine Wallet UI- Update dropdown, badges, and text. Aug 6, 2024
@cpcramer cpcramer changed the title chore: Refine Wallet UI- Update dropdown, badges, and text. chore: Refine Wallet UI - Update dropdown, badges, and text. Aug 6, 2024
@cpcramer cpcramer force-pushed the paul/simplify-wallet-dropdown-copy branch from d617f96 to bab9fe6 Compare August 7, 2024 00:11
@Zizzamia Zizzamia merged commit d22bea0 into main Aug 7, 2024
@Zizzamia Zizzamia deleted the paul/simplify-wallet-dropdown-copy branch August 7, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Development

Successfully merging this pull request may close these issues.

2 participants