Skip to content

Support for invoking and processing queries#141

Merged
DeRauk merged 20 commits intocoinbase:masterfrom
dwillett:features/query-support
Apr 15, 2022
Merged

Support for invoking and processing queries#141
DeRauk merged 20 commits intocoinbase:masterfrom
dwillett:features/query-support

Conversation

@dwillett
Copy link
Copy Markdown
Contributor

@dwillett dwillett commented Feb 18, 2022

Adding support for queries.

This PR leaves a few things unimplemented:

  • A "catch-all" query handler syntax similar to signal handlers.
  • Support for reserved query handler behaviors such as responding to __stack_trace, or support for populating the query UX on the web interface.

Copy link
Copy Markdown
Contributor

@antstorm antstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, but this is really great progress 🎉

Dave Willett added 6 commits March 24, 2022 11:27
Made a handful of changes on approach from the initial spike. This
is operating under an assumption that the added EventTarget type for
query is a valid approach
Also adding a second targeted query handler to spec
@dwillett dwillett force-pushed the features/query-support branch from f641e1f to 116b02e Compare March 24, 2022 20:30
@dwillett dwillett marked this pull request as ready for review April 12, 2022 16:11
Copy link
Copy Markdown
Contributor

@antstorm antstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@DeRauk DeRauk merged commit 398fd24 into coinbase:master Apr 15, 2022
@dwillett dwillett deleted the features/query-support branch April 18, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants