fix: Add missing EVM network mappings to @x402/evm #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v2 EVM mechanism package was missing USDC address mappings for most supported networks. Only Base, Base Sepolia, Ethereum, and Sepolia were configured, causing transactions on other networks to fail or use wrong addresses. Added mappings for: - Avalanche (mainnet + Fuji testnet) - Polygon (mainnet + Amoy testnet) - Sei (mainnet + testnet) - Abstract (mainnet + testnet) - IoTeX - Peaq - Story - Educhain - SKALE Base Sepolia Also updated getEvmChainId() to include all supported networks. Fixes coinbase#773
🟡 Heimdall Review Status
|
|
@madisoncarter1234 is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thanks for the suggestions @madisoncarter1234! We are planning some changes to the defaultAsset policy, see #799. I will come back to this once it is finalized. In any case, getDefaultAsset() is only needed for the moneyParser of eg price: '$0.001', you can always use 'asset' and 'amount' (in atomic units) instead to use your preferred (EIP-3009) token |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@x402/evmpackage was missing USDC address mappings for most supported networksgetDefaultAsset()Root Cause of #773
The transactions in the issue were sent to
0x036CbD53842c5426634e7929541eC2318f3dCF7e(Base Sepolia USDC)on SKALE chain, where that address has no code. This explains:
The SKALE USDC contract (
0x2e08028E3C4c2356572E096d8EF835cD5C6030bD) is fully EIP-3009 compliant.Changes
packages/mechanisms/evm/src/exact/server/scheme.ts- Added all 15 EVM networks togetDefaultAsset()packages/mechanisms/evm/src/utils.ts- Added all networks togetEvmChainId()Fixes #773