Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #39 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 268 268
Branches 40 40
=========================================
Hits 268 268 ☔ View full report in Codecov by Sentry. |
This reverts commit ac3319d.
cottsay
approved these changes
Feb 8, 2024
Member
cottsay
left a comment
cottsay
left a comment
There was a problem hiding this comment.
I don't have much context on dev containers, but I don't see anything alarming here either.
| # Download constraints | ||
| curl -sSLo $CONSTRAINTS_FILE $CONSTRAINTS_URL | ||
| # Remove this package from constraints | ||
| sed -i "/^$(python setup.py --name)@/d" $CONSTRAINTS_FILE |
Member
There was a problem hiding this comment.
I changed this line in colcon/ci#14 to support extensions that don't have a setup.py. You could copy the new logic here, or just drop in colcon-clean if you like.
ruffsl
added a commit
to ruffsl/colcon-cache
that referenced
this pull request
May 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approximates colcon's CI while still streamlining development over the previous Dockerfile build setup. Also, the Dockerfile build setup (using colcon itself as the build tool) was failing to pass tests due to some file hierarchy assumptions with copyright checks using pytest, such as auto generated site files missing copyright headers.