Skip to content

Fix test compatibility with Python < 3.8#731

Merged
cottsay merged 1 commit into
masterfrom
cottsay/py38-compat
Mar 31, 2026
Merged

Fix test compatibility with Python < 3.8#731
cottsay merged 1 commit into
masterfrom
cottsay/py38-compat

Conversation

@cottsay
Copy link
Copy Markdown
Member

@cottsay cottsay commented Mar 31, 2026

This is a simple compatibility fix for Python versions prior to 3.8, where patch.dict() did not return the patched instance of the object. Since it has just been patched, we can refer to it directly.

This is a simple compatibility fix for Python versions prior to 3.8,
where `patch.dict()` did not return the patched instance of the object.
Since it has just been patched, we can refer to it directly.
@cottsay cottsay self-assigned this Mar 31, 2026
@cottsay cottsay added bug Something isn't working good first issue Good for newcomers labels Mar 31, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.21%. Comparing base (aee8364) to head (0f18fd3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   87.21%   87.21%           
=======================================
  Files          69       69           
  Lines        4106     4106           
  Branches      709      709           
=======================================
  Hits         3581     3581           
  Misses        414      414           
  Partials      111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cottsay cottsay merged commit 5d6a1b0 into master Mar 31, 2026
46 checks passed
@cottsay cottsay deleted the cottsay/py38-compat branch March 31, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working good first issue Good for newcomers

Development

Successfully merging this pull request may close these issues.

2 participants