Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,8 @@ object ASCIITableFormat {

object ASCIITableFormats {

private val sqlParser = new SqlParser()

private def formatExtractExpr(s: String): String = {
sqlParser.parseExpression(s).toString()
SqlParser.parseExpression(s).toString()
}

implicit class StringFormattingOps(val s: String) extends AnyVal {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ case class HiveSink(
) extends Sink {

def saveDataFrame(df: DataFrame)(implicit sqlContext: SQLContext): Unit = {
df.saveAsTable(tableName, SaveMode.Overwrite)
df.write.mode(SaveMode.Overwrite).saveAsTable(tableName)
}

override def toString: String =
Expand All @@ -50,7 +50,7 @@ case class ParquetSink(
) extends Sink {

def saveDataFrame(df: DataFrame)(implicit sqlContext: SQLContext): Unit = {
df.saveAsParquetFile(path)
df.write.parquet(path)
}

override def toString: String =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,22 +24,18 @@ class TransformerSpec extends FlatSpec with TestSparkContext {
val isActive = true
val withAllOther = true

// Can't call 'day_of_week' with String
val badFunctionType = ModelFeature(isActive, "advertisement", "f1", "day_of_week(adv_site, 'UTC')", Top(95.0, allOther = false))

// Not enough parameters for 'concat'
val wrongParametersCount = ModelFeature(isActive, "advertisement", "f2", "concat(adv_site)", Top(95.0, allOther = false))

val df = sqlContext.createDataFrame(sc.parallelize(input), schema)

"Transformer" should "report failed feature extraction" in {
val features = Transformer.extractFeatures(df, Seq(badFunctionType, wrongParametersCount))
val features = Transformer.extractFeatures(df, Seq(wrongParametersCount))
assert(features.isLeft)
val errors = features.fold(identity, _ => sys.error("Should not be here"))

assert(errors.length == 2)
assert(errors(0).feature == badFunctionType)
assert(errors(1).feature == wrongParametersCount)
assert(errors.length == 1)
assert(errors(0).feature == wrongParametersCount)
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ case class ModelFeature(

object ModelFeature {

// Validate extract expressions using SqlParser that used in DataFrame.selectExpr
private val sqlParser = new SqlParser()

def parse(feature: String, config: Config, path: String): ValidationNel[String, ModelFeature] = {
parse(feature, config.getConfig(path))
}
Expand All @@ -33,7 +30,7 @@ object ModelFeature {
def expression(p: String) = {
import scalaz.Validation.FlatMap._
string(p).flatMap { input =>
Try(sqlParser.parseExpression(input)) match {
Try(SqlParser.parseExpression(input)) match {
case Success(parsed) => input.successNel
case Failure(err) => s"Failed to parse extract expression: $err".failureNel
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class IndexTransformer(input: DataFrame @@ Transformer.Features) extends Categor

val df = scalaz.Tag.unwrap(input)

import org.apache.spark.sql.functions._
import org.apache.spark.sql.functions.col

// Group and count by extract value
val grouped: DataFrame = df.filter(df(f).isNotNull).groupBy(f).count()
Expand Down
2 changes: 1 addition & 1 deletion project/Dependency.scala
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ object Dependency {
val Guava = "14.0.1" // match to Spark Guava version

// Spark
val Spark = "1.3.0-cdh5.4.2"
val Spark = "1.5.0-cdh5.5.1"

// Database
val Slick = "3.0.0"
Expand Down
2 changes: 1 addition & 1 deletion version.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import VersionScheme.Keys._

isRelease in ThisBuild := sys.props("release") == "true"

versionPrefix in ThisBuild := "0.0.13"
versionPrefix in ThisBuild := "0.1.0"

version in ThisBuild <<= Def.setting[String] {
if (isRelease.value) {
Expand Down