Conversation
nodchip
reviewed
Mar 18, 2024
| int maxProfit(vector<int>& prices) { | ||
| int minPrice = INT_MAX; | ||
| int maxProfit = 0; | ||
| for(int i = 0; i < prices.size(); i++) { |
There was a problem hiding this comment.
prices[i] の形でしか prices を参照していないため、コードをシンプルにするため、 for (int price : prices) { でループを回したほうが良いと思います。
Owner
Author
There was a problem hiding this comment.
手癖でインデックスを使うfor文で回してしまっていたので今後使い分けます。
| class Solution { | ||
| public: | ||
| int maxProfit(vector<int>& prices) { | ||
| int minPrice = INT_MAX; |
There was a problem hiding this comment.
個人的には std::numeric_limits<int>::max() を使いたいです。
Owner
Author
There was a problem hiding this comment.
CのマクロではなくC++の標準ライブラリから使う機能を選んだほうが良さそうですね、以後気をつけます。
| public: | ||
| int maxProfit(vector<int>& prices) { | ||
| int minPrice = INT_MAX; | ||
| int maxProfit = 0; |
There was a problem hiding this comment.
関数名と同じ変数名を使うと、名前を隠してしまい、思わぬバグを入れる場合があります。できれば異なる名前を付けたほうが良いと思います。
colorbox
changed the title
121. Best Time to Buy and Sell Stock
colorbox
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.