Conversation
nodchip
reviewed
Mar 29, 2024
| class Solution { | ||
| public: | ||
| bool isAnagram(string s, string t) { | ||
| if (s.length() != t.length()) { return false; } |
There was a problem hiding this comment.
早期に枝刈りしたいのであれば、この文を入れても良いと思います。なくても良いと思います。
242/2.cpp
Outdated
| char_counter[c]--; | ||
| } | ||
|
|
||
| for (const pair<char, int> pair : char_counter) { |
There was a problem hiding this comment.
for (const auto& pair : char_counter) { としたほうがシンプルだと思います。
また、 pair<char, int> であれば大丈夫なのですが、サイズが sizeof(int64_t) を超えるオブジェクトで拡張 for 文を回す際は、 const 参照で回したほうが良いと思います。
Owner
Author
There was a problem hiding this comment.
型を明示できる方が良いと思っていましたが、autoを適宜使っていきます。
const参照勉強になります。
sizeof(int64_t)の閾値についても気にするようにします。
oda
reviewed
Mar 29, 2024
242/2.cpp
Outdated
| } | ||
|
|
||
| for (const pair<char, int> pair : char_counter) { | ||
| if (char_counter[pair.first]) { return false; } |
Owner
Author
There was a problem hiding this comment.
char_counterを介する意味ないですね、冗長でした
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
242. Valid Anagram