Skip to content

Add support for arbitrary ANSI color#166

Merged
spenserblack merged 2 commits intocolored-rs:masterfrom
TessApp:master
Apr 4, 2025
Merged

Add support for arbitrary ANSI color#166
spenserblack merged 2 commits intocolored-rs:masterfrom
TessApp:master

Conversation

@Asthowen
Copy link
Contributor

Add ansi_color and on_ansi_color on Colorize trait.

Copy link
Collaborator

@kurtlawrence kurtlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry under breaking changes

@kurtlawrence kurtlawrence changed the base branch from master to v3 February 26, 2024 23:06
@kurtlawrence kurtlawrence added the breaking Will need a major version bump label Feb 26, 2024
@spenserblack
Copy link
Collaborator

Oops, sorry, my attention has been on more recently active PRs. The master branch is now on v3, so could you target that for your PR and make any necessary changes (the changelog, for example)?

@Asthowen Asthowen changed the base branch from v3 to master January 14, 2025 18:01
@Asthowen
Copy link
Contributor Author

It's done 👍.

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Asthowen
Copy link
Contributor Author

Asthowen commented Apr 4, 2025

Hello,
Are you still interested in this PR or can I close it?

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spenserblack
Copy link
Collaborator

Thanks, sorry for the wait! I think I'll make a new release soon. Feel free to ping me if I'm taking too long 😅

@spenserblack spenserblack merged commit e3bb575 into colored-rs:master Apr 4, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Will need a major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants