This repository was archived by the owner on Jul 14, 2020. It is now read-only.
Update instructions on how to build Bitcoin HTLC#90
Merged
Conversation
Instead of a table that instructs to concatenate hex strings, we provide a table with replacement offsets. This is much easier to implement than less error-prone. Resolves #82.
thomaseizinger
force-pushed
the
thomaseizinger-patch-1
branch
2 times, most recently
from
6164e59 to
129cc15
Compare
D4nte
approved these changes
Jul 4, 2019
tcharding
approved these changes
Jul 5, 2019
da-kami
suggested changes
Jul 5, 2019
Member
da-kami
left a comment
da-kami
left a comment
There was a problem hiding this comment.
I approve these changes in general, but we should discuss if we really want to rename expiry to refund_timestamp.
expiry describes the HTLC on a more abstract level, refund_timestamp for our specific use-case.
From my point of view the higher level protocol always defines the lower level, and https://github.com/comit-network/RFCs/blob/master/RFC-003-SWAP-Basic.md defines it as expiry - refund_timestamp is not mentioned there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of a table that instructs to concatenate hex strings, we provide a table with replacement offsets. This is much easier to implement than less error-prone.
Resolves #82.
I have also noticed a mismatch in the naming. We sometimes use
expiry(in the SWAP REQUEST message) but the rest of the RFC usesrefund_timestamp. To not block this PR, I created an issue to fix this: #89