Skip to content

Add spike for LN as alpha ledger#6

Merged
bonomat merged 23 commits into
masterfrom
hodl-invoice
May 3, 2019
Merged

Add spike for LN as alpha ledger#6
bonomat merged 23 commits into
masterfrom
hodl-invoice

Conversation

@bonomat
Copy link
Copy Markdown
Member

@bonomat bonomat commented Apr 24, 2019

Spike for supporting Lightning Network as Alpha Ledger.

Resolves comit-network/comit-rs#841

@ghost ghost assigned bonomat Apr 24, 2019
@ghost ghost added the review label Apr 24, 2019
Comment thread 0003-lightning-as-alpha-ledger.md Outdated
Comment thread 0003-lightning-as-alpha-ledger.md Outdated
Comment thread 0003-lightning-as-alpha-ledger.md Outdated
Comment thread 0003-lightning-as-alpha-ledger.md Outdated
Comment thread 0003-lightning-as-alpha-ledger.md Outdated
Comment thread 0003-lightning-as-alpha-ledger.md Outdated
Comment thread 0003-lightning-as-alpha-ledger.md Outdated
Comment thread 0003-lightning-as-alpha-ledger.md Outdated
Comment thread 0003-lightning-as-alpha-ledger.md Outdated
Comment thread 0003-lightning-as-alpha-ledger.md Outdated
Comment thread 0003-lightning-as-alpha-ledger.md Outdated
Comment thread 0003-lightning-as-alpha-ledger.md Outdated
Comment thread 0003-lightning-as-alpha-ledger.md Outdated
Copy link
Copy Markdown
Contributor

@D4nte D4nte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and exciting stuff!

Comment thread 0003-lightning-as-alpha-ledger.adoc Outdated
Comment thread 0003-lightning-as-alpha-ledger.adoc
Comment thread 0003-lightning-as-alpha-ledger.adoc
Comment thread 0003-lightning-as-alpha-ledger.adoc Outdated
Comment thread 0003-lightning-as-alpha-ledger.adoc
Comment thread 0003-lightning-as-alpha-ledger.adoc
Comment thread 0003-lightning-as-alpha-ledger.adoc Outdated
Comment thread 0003-lightning-as-alpha-ledger.adoc
Comment thread 0003-lightning-as-alpha-ledger.adoc Outdated
@D4nte
Copy link
Copy Markdown
Contributor

D4nte commented Apr 30, 2019

@thomaseizinger you have quite a lot of comments that I don't think were in the original spike you wrote with @LLFourn. Is there any notes or discussions that you had that were not reported in the original spike?

@thomaseizinger
Copy link
Copy Markdown
Contributor

thomaseizinger commented Apr 30, 2019

@thomaseizinger you have quite a lot of comments that I don't think were in the original spike you wrote with @LLFourn. Is there any notes or discussions that you had that were not reported in the original spike?

We never wrote a spike, we only started looking into the topic for ~1h. There were quite a few unanswered questions and open points at that point. All we wrote down was the current state, which was mostly about getting the new feature to actually work + what you can do with it.
I am bit surprised about your expectation that our spike was done/complete.

Some of the open points have now been answered/addressed in this spike, hence my comments.

Comment thread 0003-lightning-as-alpha-ledger.adoc Outdated
Comment thread 0003-lightning-as-alpha-ledger.adoc
Comment thread 0003-lightning-as-alpha-ledger.adoc Outdated
Comment thread 0003-lightning-as-alpha-ledger.adoc Outdated
Comment thread 0003-lightning-as-alpha-ledger.adoc Outdated
Comment thread 0003-lightning-as-alpha-ledger.adoc
Comment thread 0003-lightning-as-alpha-ledger.adoc
@D4nte
Copy link
Copy Markdown
Contributor

D4nte commented May 2, 2019

@thomaseizinger you have quite a lot of comments that I don't think were in the original spike you wrote with @LLFourn. Is there any notes or discussions that you had that were not reported in the original spike?

We never wrote a spike, we only started looking into the topic for ~1h. There were quite a few unanswered questions and open points at that point. All we wrote down was the current state, which was mostly about getting the new feature to actually work + what you can do with it.
I am bit surprised about your expectation that our spike was done/complete.

Some of the open points have now been answered/addressed in this spike, hence my comments.

Clearly a misunderstanding. I thought the take over was to organise the work to be done. I understood that the spike was finished hence my surprise of the initial content length. Now I wonder why it was handed over. Clearly I missed something🤔

@thomaseizinger
Copy link
Copy Markdown
Contributor

thomaseizinger commented May 2, 2019

Clearly a misunderstanding. I thought the take over was to organise the work to be done. I understood that the spike was finished hence my surprise of the initial content length. Now I wonder why it was handed over. Clearly I missed something 🤔

IIRC it was handed over because I started to work on libp2p stuff and @LLFourn started to dig into Scriptless-Scripts.
This happened as a result of discussing, who is the most interested in working on which topics. I think you and @bonomat were keen on Lightning, hence you took over were we left of.

@D4nte
Copy link
Copy Markdown
Contributor

D4nte commented May 2, 2019

I see no pending comments, is this ready for merge?

Comment thread 0003-lightning-as-alpha-ledger.adoc Outdated
Comment thread 0003-lightning-as-alpha-ledger.adoc
@bonomat bonomat merged commit 478a823 into master May 3, 2019
@bonomat bonomat removed the review label May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⚗️Investigate compatibility of RFC003 and LND with HODL invoices

4 participants