Conversation
geohot
commented
Nov 19, 2019
Contributor
|
Sounds like nanosleep is the way to go here. It is designed to be interrupted, has nice exit codes and even stores the remaining time when interrupted in a new struct. |
pd0wm
force-pushed
the
signal
branch
3 times, most recently
from
d5b69d4 to
3e7f755
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, remove randomness unless there's a real justification for it. In general, unless you absolutely need it, randomness shouldn't be used.
Secondly, with uids being pids, I think the signalling solution is obvious. The polling process can sleep until the publishing process decides it's time to wake it up. I don't know the nuance here, but usleep can be exited by EINTR, though I think the signal handler might have to be configured to do that.
You could get more fine grained with the poll, where the subscriber says if it's blocked on a given socket to avoid spurious wakeups (right now it wakes on all subscribed sockets), but this is a perf optimization for later and maybe not needed at all.
Right now this segfaults with python demo.py, and I don't know why. In general, this software needs a much better test suite, it underlies all of system stability and has to deal with many different orders of events.