visionipc: fix assert in getAvailableStreams#562
Closed
deanlee wants to merge 2 commits intocommaai:masterfrom
Closed
visionipc: fix assert in getAvailableStreams#562deanlee wants to merge 2 commits intocommaai:masterfrom
deanlee wants to merge 2 commits intocommaai:masterfrom
Conversation
Contributor
Author
|
VipcClient::recv and vipcClient::connect have similar problems, e.g. vipcClient:connect will returns true even if an attempt is made to connect to a non-existent stream type.considering use another pr to fix these issues. @adeebshihadeh : In addition, vipc currently only uses yuv type buffs, and rgb seems to have been deprecated. Can this part of the code be deleted? This can make vipc's code much cleaner. |
This was referenced Dec 19, 2023
Contributor
|
Doesn't the map still use it? |
Contributor
Author
|
the map_render creates vipc buffer as yuv. Looks like a bug, though it probably doesn't actually affect the result. |
Contributor
Author
|
closed , moved to #624 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the vipc client still can connect to the ipc path even if the camerad is not running. This could be due to the camerad not shutting down properly and the ipc path not being removed.
ipc_sendrecv_with_fdswill returns -1 In this case. this causes the following assertion to fail.This bug can be reproduced by clicking “preview driver camera" button quickly and continuously in the UI interface.