Add this for future Blindspot recognition#7
Closed
arne182 wants to merge 1 commit intocommaai:masterfrom
Closed
Conversation
I am not sure if a boolean is good instead of sending the distance to object but it would be interesting to talk about this.
rbiasini
reviewed
Oct 1, 2019
| altButton3 @8; | ||
| } | ||
| } | ||
| blindspot @27 :Bool; # Is there something blocking the lane change |
Contributor
There was a problem hiding this comment.
I think at least distinguishing between left VS right should be required.
Also, maybe anything that has to do with perception should be handled by radard. I'll think about this.
Contributor
Author
|
I also thought that having both is good in the beginning. But if we limit the auto Lane change based on blinker on direction. You should only have a violation in that direction. Checking both sides requires more code on Toyota and does not give more valuable data. Later it could be used for crash avoidance. But that is another topic. |
Collaborator
|
Is this being used in forks? I'd be fine with upstreaming blindspot stuff. |
Contributor
Author
|
We are working on it currently |
Contributor
Author
|
Will reopen a PR to be up to date with master. |
Kirito3481
pushed a commit
to Kirito3481/msgq
that referenced
this pull request
Dec 4, 2024
* NNFF: Cereal logging and startup alert * fill up lateralControlState
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure if a boolean is good instead of sending the distance to object but it would be interesting to talk about this.