Conversation
geohot
pushed a commit
that referenced
this pull request
Jun 17, 2018
0dcd84d Toyota safety: integer division bug 9a268f3 Toyota Safety: cleaner var types 8638650 bump panda version 9ab6a56 gmlan recv test a1a2d97 gmlan test 8efa389 detect ack f5fab4b nicer err ad4d423 add gmlan fail count bb41ff7 test 998f7c0 oops, set recessive 80051be autoretry on chime 813218d GM: allowing higher brakes in Volt, so decel can reach between 3 and 3.5 m/s2 74ad3d6 GM: max param definitions 38a9ea9 added gm safety for steering (#123) bf5db45 Safety: made the driver steer check common so it can be shared across multiple safety files ef079e6 Safety: made rate limit check also common dc3cc24 Safety: made common the max torque check as well dbc3568 removing extra spaces 1966bdf Safety: made real time rate limit check a shared function e214477 use timer for can bitbanging cb92733 minor bitbang refactor ed2920c support extended addressing in canbitbang 36df0996 move speed be46c7a Merge pull request #122 from commaai/gmbitbang 7edc88e put that back fa66e4b Revert "handle rollover" 2ce3a26a handle rollover 223a1fb cleanin it up 1ba7907 that space tho d917386 bitbanging works 74af441 can crc 932d727 bit stuffing support be22522 bros ok match bros 55da0b6 rigol yea, dj pauly d yea a577583 working on gmbitbang 875c2bd3 Cadillac: block OP messages if OP is on 7caba24 Addition to Bosch safety to support Hatchback (#111) 63ca46b modify before we forward bf70f51 Safety: increase buffer for sampled signals. TBD a violation feedback from board to prevent car faults b0541a8 Cadillac: monitoring the 4 torque messages independently cd1dba9 Cadillac: fixed bug in regression safety ca0b6be Cadillac: fixed typo. Need better regression tests to catch this d9f1e61 Cadillac: simplified the ignition code by removing the timeout logic and resetting controls_allowed = 0 at each init 293fd1a GM: using real ignition logic. Creedit to Jamezz 8fa507b GM: simplified max steer check logic, Cadillac: fixed can parsing bug c7e2c2d Cadillac (#119) 83bcaa3 small logic cleanup (#118) 9d92bf2 Cadillac: need to specify car name in const 79ab5af Toyota: moved common functions into safety header file 40c8dda Cadillac ignition: simplified logic 69be556 Cadillac: better ignition logic d176220 Ignition: made a default hook for GPIO bea5187 Cadillac: added max steer safety dbc11a1 Cadillac: always controls allowed for now ace232a Cadillac: ignition bug e2c89d6 Cadillac: changed ignition logic to be based on can presence 528f901 Cadillac: simpler ignition logic 4e79ecf Cadillac: added safety file placeholder git-subtree-dir: panda git-subtree-split: 0dcd84d
adhintz
added a commit
to adhintz/openpilot
that referenced
this pull request
Dec 14, 2018
* Squashed 'opendbc/' changes from 3f6cd74..e108b6b e108b6b Add more Sign recognitions (commaai#126) 6e8a363 Add GM FCW Alert (Take 2) (commaai#125) 368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124) 98b5f66 Add GM FCW dashboard alert (commaai#123) 71b7588 Adds dbc for 2019 Honda Insight (commaai#122) git-subtree-dir: opendbc git-subtree-split: e108b6b * Squashed 'pyextra/' changes from fb152de..8cc1594 8cc1594 update overpy 2c18997 switch to forked version of overpy git-subtree-dir: pyextra git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be * openpilot v0.5.7 release * 0.5.7 hotfixes * On pedal press, if in steer error state, do not send ACC cancel button message. Sending the ACC cancel button message in this state causes the car to display warnings. * set the new ret.openpilotLongitudinalControl = False
adhintz
added a commit
to adhintz/openpilot
that referenced
this pull request
Dec 18, 2018
* GM: remove refactor leftovers (commaai#440) * Move calibration values (commaai#441) * initial commit * moved constants * Keep steering on radar fault (commaai#442) * Add initial support for Holden/Opel Astra BK (commaai#431) * Added Astra support to README and RELEASE notes (commaai#443) * Honda Nidec: avoid giraffe setting alert when car is turned off (commaai#449) * Adding support for 2018 GMC Acadia Denali (commaai#453) * added acadia * adding acadia * adding acadia * Update radar_interface.py * adding acadia * refactored * fixed tuning * Adding acadia * Update interface.py * fixed whitespace * fixed whitespace * ACC cancel button * GM: Cadillac ATS Coupe 2018 support (commaai#445) * GM: Cadillac ATS Coupe 2018 support * Missed adding Cadillac ATS * Fixed Capitalization + Made CT6 Comment Cleaner (commaai#456) * Update README.md * Updated CT6 comment * Add Lexus RX450HL as sub to RX450H (commaai#458) Add Lexus RX450HL as sub to RX450H * on gas pedal press, send cancel ACC button to cancel OpenPilot * try sending +1 counter so our message isn't a duplicate * only do the accel pedal for specific cars * do accel pedal for all models * try always sending 1 for cancel acc frame * clean up comments and remove unused moving_fast * remove unused make can msg parameters * try incrementing wheel button counter by 2 to see if that works better for cancel * Squashed 'opendbc/' changes from 3f6cd74..e108b6b e108b6b Add more Sign recognitions (commaai#126) 6e8a363 Add GM FCW Alert (Take 2) (commaai#125) 368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124) 98b5f66 Add GM FCW dashboard alert (commaai#123) 71b7588 Adds dbc for 2019 Honda Insight (commaai#122) git-subtree-dir: opendbc git-subtree-split: e108b6b * Squashed 'pyextra/' changes from fb152de..8cc1594 8cc1594 update overpy 2c18997 switch to forked version of overpy git-subtree-dir: pyextra git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be * openpilot v0.5.7 release * try to simplify message logic * clean up code * move Chrylser into main table in readme * 0.5.7 hotfixes * On pedal press, if in steer error state, do not send ACC cancel button message. Sending the ACC cancel button message in this state causes the car to display warnings. * set the new ret.openpilotLongitudinalControl = False * hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469) * generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk * disable pedal_gas for now to do a devel release. Sending 23b might fault other cars. * add jeep grand cherokee 2017 to readme car list
adhintz
added a commit
to adhintz/openpilot
that referenced
this pull request
Dec 20, 2018
) * GM: remove refactor leftovers (commaai#440) * Move calibration values (commaai#441) * initial commit * moved constants * Keep steering on radar fault (commaai#442) * Add initial support for Holden/Opel Astra BK (commaai#431) * Added Astra support to README and RELEASE notes (commaai#443) * Honda Nidec: avoid giraffe setting alert when car is turned off (commaai#449) * Adding support for 2018 GMC Acadia Denali (commaai#453) * added acadia * adding acadia * adding acadia * Update radar_interface.py * adding acadia * refactored * fixed tuning * Adding acadia * Update interface.py * fixed whitespace * fixed whitespace * ACC cancel button * GM: Cadillac ATS Coupe 2018 support (commaai#445) * GM: Cadillac ATS Coupe 2018 support * Missed adding Cadillac ATS * Fixed Capitalization + Made CT6 Comment Cleaner (commaai#456) * Update README.md * Updated CT6 comment * Add Lexus RX450HL as sub to RX450H (commaai#458) Add Lexus RX450HL as sub to RX450H * on gas pedal press, send cancel ACC button to cancel OpenPilot * try sending +1 counter so our message isn't a duplicate * only do the accel pedal for specific cars * do accel pedal for all models * try always sending 1 for cancel acc frame * clean up comments and remove unused moving_fast * remove unused make can msg parameters * try incrementing wheel button counter by 2 to see if that works better for cancel * Squashed 'opendbc/' changes from 3f6cd74..e108b6b e108b6b Add more Sign recognitions (commaai#126) 6e8a363 Add GM FCW Alert (Take 2) (commaai#125) 368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124) 98b5f66 Add GM FCW dashboard alert (commaai#123) 71b7588 Adds dbc for 2019 Honda Insight (commaai#122) git-subtree-dir: opendbc git-subtree-split: e108b6b * Squashed 'pyextra/' changes from fb152de..8cc1594 8cc1594 update overpy 2c18997 switch to forked version of overpy git-subtree-dir: pyextra git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be * openpilot v0.5.7 release * try to simplify message logic * clean up code * move Chrylser into main table in readme * 0.5.7 hotfixes * On pedal press, if in steer error state, do not send ACC cancel button message. Sending the ACC cancel button message in this state causes the car to display warnings. * set the new ret.openpilotLongitudinalControl = False * hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469) * generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk * disable pedal_gas for now to do a devel release. Sending 23b might fault other cars. * add jeep grand cherokee 2017 to readme car list * separate fingerprint for trailhawk. separate wheelbase for Cherokee
adhintz
added a commit
to adhintz/openpilot
that referenced
this pull request
Dec 29, 2018
* GM: remove refactor leftovers (commaai#440) * Move calibration values (commaai#441) * initial commit * moved constants * Keep steering on radar fault (commaai#442) * Add initial support for Holden/Opel Astra BK (commaai#431) * Added Astra support to README and RELEASE notes (commaai#443) * Honda Nidec: avoid giraffe setting alert when car is turned off (commaai#449) * Adding support for 2018 GMC Acadia Denali (commaai#453) * added acadia * adding acadia * adding acadia * Update radar_interface.py * adding acadia * refactored * fixed tuning * Adding acadia * Update interface.py * fixed whitespace * fixed whitespace * ACC cancel button * GM: Cadillac ATS Coupe 2018 support (commaai#445) * GM: Cadillac ATS Coupe 2018 support * Missed adding Cadillac ATS * Fixed Capitalization + Made CT6 Comment Cleaner (commaai#456) * Update README.md * Updated CT6 comment * Add Lexus RX450HL as sub to RX450H (commaai#458) Add Lexus RX450HL as sub to RX450H * on gas pedal press, send cancel ACC button to cancel OpenPilot * try sending +1 counter so our message isn't a duplicate * only do the accel pedal for specific cars * do accel pedal for all models * try always sending 1 for cancel acc frame * clean up comments and remove unused moving_fast * remove unused make can msg parameters * try incrementing wheel button counter by 2 to see if that works better for cancel * Squashed 'opendbc/' changes from 3f6cd74..e108b6b e108b6b Add more Sign recognitions (commaai#126) 6e8a363 Add GM FCW Alert (Take 2) (commaai#125) 368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124) 98b5f66 Add GM FCW dashboard alert (commaai#123) 71b7588 Adds dbc for 2019 Honda Insight (commaai#122) git-subtree-dir: opendbc git-subtree-split: e108b6b * Squashed 'pyextra/' changes from fb152de..8cc1594 8cc1594 update overpy 2c18997 switch to forked version of overpy git-subtree-dir: pyextra git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be * openpilot v0.5.7 release * try to simplify message logic * clean up code * move Chrylser into main table in readme * 0.5.7 hotfixes * On pedal press, if in steer error state, do not send ACC cancel button message. Sending the ACC cancel button message in this state causes the car to display warnings. * set the new ret.openpilotLongitudinalControl = False * hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469) * generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk * disable pedal_gas for now to do a devel release. Sending 23b might fault other cars. * add jeep grand cherokee 2017 to readme car list * separate fingerprint for trailhawk. separate wheelbase for Cherokee * add fingerprint for Pacifica 2019 Hybrid.
adhintz
added a commit
to adhintz/openpilot
that referenced
this pull request
Dec 29, 2018
* remove logging from devel * Revert "remove logging from devel" This reverts commit 2145747. * Squashed 'opendbc/' changes from 3f6cd74..e108b6b e108b6b Add more Sign recognitions (commaai#126) 6e8a363 Add GM FCW Alert (Take 2) (commaai#125) 368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124) 98b5f66 Add GM FCW dashboard alert (commaai#123) 71b7588 Adds dbc for 2019 Honda Insight (commaai#122) git-subtree-dir: opendbc git-subtree-split: e108b6b * Squashed 'pyextra/' changes from fb152de..8cc1594 8cc1594 update overpy 2c18997 switch to forked version of overpy git-subtree-dir: pyextra git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be * openpilot v0.5.7 release * 0.5.7 hotfixes * On pedal press, if in steer error state, do not send ACC cancel button message. Sending the ACC cancel button message in this state causes the car to display warnings. * set the new ret.openpilotLongitudinalControl = False * hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469) * generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk * disable pedal_gas for now to do a devel release. Sending 23b might fault other cars. * add jeep grand cherokee 2017 to readme car list * 0.5.7 & Jeep Grand Cherokee 2017 support (#7) * GM: remove refactor leftovers (commaai#440) * Move calibration values (commaai#441) * initial commit * moved constants * Keep steering on radar fault (commaai#442) * Add initial support for Holden/Opel Astra BK (commaai#431) * Added Astra support to README and RELEASE notes (commaai#443) * Honda Nidec: avoid giraffe setting alert when car is turned off (commaai#449) * Adding support for 2018 GMC Acadia Denali (commaai#453) * added acadia * adding acadia * adding acadia * Update radar_interface.py * adding acadia * refactored * fixed tuning * Adding acadia * Update interface.py * fixed whitespace * fixed whitespace * ACC cancel button * GM: Cadillac ATS Coupe 2018 support (commaai#445) * GM: Cadillac ATS Coupe 2018 support * Missed adding Cadillac ATS * Fixed Capitalization + Made CT6 Comment Cleaner (commaai#456) * Update README.md * Updated CT6 comment * Add Lexus RX450HL as sub to RX450H (commaai#458) Add Lexus RX450HL as sub to RX450H * on gas pedal press, send cancel ACC button to cancel OpenPilot * try sending +1 counter so our message isn't a duplicate * only do the accel pedal for specific cars * do accel pedal for all models * try always sending 1 for cancel acc frame * clean up comments and remove unused moving_fast * remove unused make can msg parameters * try incrementing wheel button counter by 2 to see if that works better for cancel * Squashed 'opendbc/' changes from 3f6cd74..e108b6b e108b6b Add more Sign recognitions (commaai#126) 6e8a363 Add GM FCW Alert (Take 2) (commaai#125) 368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124) 98b5f66 Add GM FCW dashboard alert (commaai#123) 71b7588 Adds dbc for 2019 Honda Insight (commaai#122) git-subtree-dir: opendbc git-subtree-split: e108b6b * Squashed 'pyextra/' changes from fb152de..8cc1594 8cc1594 update overpy 2c18997 switch to forked version of overpy git-subtree-dir: pyextra git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be * openpilot v0.5.7 release * try to simplify message logic * clean up code * move Chrylser into main table in readme * 0.5.7 hotfixes * On pedal press, if in steer error state, do not send ACC cancel button message. Sending the ACC cancel button message in this state causes the car to display warnings. * set the new ret.openpilotLongitudinalControl = False * hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469) * generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk * disable pedal_gas for now to do a devel release. Sending 23b might fault other cars. * add jeep grand cherokee 2017 to readme car list * separate fingerprint for trailhawk. separate wheelbase for Cherokee * separate fingerprint for trailhawk. separate wheelbase for Cherokee (#8) * GM: remove refactor leftovers (commaai#440) * Move calibration values (commaai#441) * initial commit * moved constants * Keep steering on radar fault (commaai#442) * Add initial support for Holden/Opel Astra BK (commaai#431) * Added Astra support to README and RELEASE notes (commaai#443) * Honda Nidec: avoid giraffe setting alert when car is turned off (commaai#449) * Adding support for 2018 GMC Acadia Denali (commaai#453) * added acadia * adding acadia * adding acadia * Update radar_interface.py * adding acadia * refactored * fixed tuning * Adding acadia * Update interface.py * fixed whitespace * fixed whitespace * ACC cancel button * GM: Cadillac ATS Coupe 2018 support (commaai#445) * GM: Cadillac ATS Coupe 2018 support * Missed adding Cadillac ATS * Fixed Capitalization + Made CT6 Comment Cleaner (commaai#456) * Update README.md * Updated CT6 comment * Add Lexus RX450HL as sub to RX450H (commaai#458) Add Lexus RX450HL as sub to RX450H * on gas pedal press, send cancel ACC button to cancel OpenPilot * try sending +1 counter so our message isn't a duplicate * only do the accel pedal for specific cars * do accel pedal for all models * try always sending 1 for cancel acc frame * clean up comments and remove unused moving_fast * remove unused make can msg parameters * try incrementing wheel button counter by 2 to see if that works better for cancel * Squashed 'opendbc/' changes from 3f6cd74..e108b6b e108b6b Add more Sign recognitions (commaai#126) 6e8a363 Add GM FCW Alert (Take 2) (commaai#125) 368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124) 98b5f66 Add GM FCW dashboard alert (commaai#123) 71b7588 Adds dbc for 2019 Honda Insight (commaai#122) git-subtree-dir: opendbc git-subtree-split: e108b6b * Squashed 'pyextra/' changes from fb152de..8cc1594 8cc1594 update overpy 2c18997 switch to forked version of overpy git-subtree-dir: pyextra git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be * openpilot v0.5.7 release * try to simplify message logic * clean up code * move Chrylser into main table in readme * 0.5.7 hotfixes * On pedal press, if in steer error state, do not send ACC cancel button message. Sending the ACC cancel button message in this state causes the car to display warnings. * set the new ret.openpilotLongitudinalControl = False * hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469) * generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk * disable pedal_gas for now to do a devel release. Sending 23b might fault other cars. * add jeep grand cherokee 2017 to readme car list * separate fingerprint for trailhawk. separate wheelbase for Cherokee * add fingerprint for Pacifica 2019 Hybrid.
Gernby
pushed a commit
to Gernby/openpilot
that referenced
this pull request
Mar 11, 2019
…mmaai#125) * Replace UI with Perpetuo's UI * Perpetuo UI part 2 * Update ui.c (commaai#122) brake disc sign brake light indicator * Update ui.c (commaai#123) typo * Add disc brake image for brake lights in UI
Gernby
pushed a commit
to Gernby/openpilot
that referenced
this pull request
Mar 11, 2019
…mmaai#125) * Replace UI with Perpetuo's UI * Perpetuo UI part 2 * Update ui.c (commaai#122) brake disc sign brake light indicator * Update ui.c (commaai#123) typo * Add disc brake image for brake lights in UI
mespiritu
pushed a commit
to mespiritu/openpilot
that referenced
this pull request
Apr 1, 2019
Tuned dynamic follow arrays for more natural braking and acceleration, added branch tagging for debugging
avolmensky
pushed a commit
to avolmensky/openpilot
that referenced
this pull request
Jun 10, 2019
avolmensky
pushed a commit
to avolmensky/openpilot
that referenced
this pull request
Jun 10, 2019
This reverts commit 98b5f66.
avolmensky
pushed a commit
to avolmensky/openpilot
that referenced
this pull request
Jun 30, 2019
* added gm safety for steering * safety tests done for safety_gm
weimou
pushed a commit
to SFtoLA/openpilot
that referenced
this pull request
May 6, 2021
* deprecated lateralPlan.steeringAngle * rename LiveMpc curvature * more deprecated * add angle control * deprecate * Revert "deprecate" This reverts commit 330f96208b514dfcdcb181bd4888c9a863b52185.
nworb-cire
referenced
this pull request
in opgm/openpilot
Aug 2, 2024
* add build_dev * udpate build_release
wtogami
pushed a commit
to wtogami/openpilot
that referenced
this pull request
Mar 25, 2025
Changed the PR reference format from (`commaai#123`) to (PR-123) in squash commit messages to prevent GitHub from automatically adding reference comments to PRs when `master-dev-c3-new` is force pushed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the space for public comment before we merge into release.