Conversation
|
@energee once conflicts are fixed, is this good to go? |
|
@energee, would love to merge this in if somebody can confirm it works |
|
Still testing needed? |
|
I think its close, there is a user who has it working and he may have a diff for this branch with some further changes. |
|
Side note, how is this PR a year old? |
|
Time flies 🤷♂️ |
|
Note: Variable names in interface.py are changed between 0.5 and 0.6. So it would need refactoring before merging. |
AravindaDP
left a comment
There was a problem hiding this comment.
I have worked with a Fit owner to get his vehicle working on 0.6.2 based on these changes.
Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>
Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>
Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>
Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>
Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>
Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>
|
Can we test this, @AravindaDP ? |
|
Can we verify tire stiffness value on some turns? probably needs some adjustment. I would expect ts value to be around .75 - 1 |
commaai/opendbc#100