Conversation
Kia Sorento and future Multi-Car Support (commaai#346)
|
thanks @tylergets . Is this working? I assume longitudinal control might need some work |
|
@rbiasini it's working without fault, both long + lat need some work, however. I am not sure what work that is being done for the general GM tuning in #326 applies here, but I'd be glad to test. I will get a proper cabana drive posted here over the weekend. Some initial observations, the car seems to brake unnecessarily hard in certain situations, definitely the opposite of smooth. The lkas frequency/step might be off as well. |
|
@tylergets , is longitudinal tuning still not ok? |
|
@rbiasini the current gm tune is a bit aggressive, this applies for the currently supported chevy volt as well. Tuning by @jamezz-comma in #326 and his branches greatly improves this. But because this is no different than the volt, I don't see what stops this from being good to go. I have also updated interface.py to include the malibu specific curb weight and wheelbase. |
|
As long as the car stops safely I don't see why this can't be merged. The volt longitudinal changes should help a lot with all GM. |
|
@tylergets ok, great. Will merge this for now. GM longitudinal changes from @Jamezz later. |
|
@tylergets I don't see any uploaded log from any MALIBU. Can you please share a cabana route? |
|
@tylergets merged internally. It will be included in 0.5.6 |
|
Thanks comma team! |
Increase max speed for kpBP and kiBP
…es (commaai#396) * Added an initial working implementation of the register readback and applied it to the LLCAN registers. Also fixed an init bug in CAN. * Locally disable pylint import error * Reverted change to CAN-obj->FA1R setting * Fixed misra compliance * Changed hash function name * Fixed CAN filter setting * Added voltage health test * Converted ADC to register functions * Converted clock to use register setters * Added check to see if fault status is zero after running test * Converted DAC to use register setters * Converted fan to use register setters * Converted gmlan bitbanging to use register setters * Changed over interrupt driver to use register setters. Also moved some includes and definition places for critical sections * Fixed build * Converted LLGPIO to use register setters * Converted pwm to use register setters * Fixed cold boot * Fixed health fault check in automated tests * Added comment for the future (issue commaai#367) * Converted RTC driver to use register setters * Converted SPI to use register setters * Converted timer driver to use register setters * Fixed register fault on white pandas and disabled showing of fault for release * Bump version
* color value in save screen * make obvious Y is not default * show default value * show default value * show default value * default value under description, use new function to remove dup code * end * debug * Change color * Change color * Change color * debug * debug * debug * Color saved text * Change range for min_TR * rm line
4 participants
Currently using all settings from the Chevy Volt, will update with more precise measurements when I am able to get them.