switch to system compilers (GCC on Linux, Apple Clang on macOS)#37355
Merged
adeebshihadeh merged 7 commits intomasterfrom Feb 24, 2026
Merged
switch to system compilers (GCC on Linux, Apple Clang on macOS)#37355adeebshihadeh merged 7 commits intomasterfrom
adeebshihadeh merged 7 commits intomasterfrom
Conversation
Remove hardcoded CC='clang'/CXX='clang++' and clang apt dependency. Let SCons auto-detect the system compiler instead. Build system changes: - Remove CC/CXX overrides from SConstruct - Remove clang from Ubuntu dependencies (build-essential provides gcc) - Use -Wshadow=local on GCC (matches Clang's -Wshadow behavior) - Add -Wno-cpp alongside -Wno-#warnings for GCC Cython compat - Bump installer size limit (GCC produces larger binaries) GCC compatibility fixes: - Reorder designated initializers to match declaration order - Fix -Wunused-result (assign to [[maybe_unused]] variable) - Rename constructor/lambda params that shadow members/locals - Replace decltype(&pclose) with explicit function pointer type - Replace GNU array designated initializers with plain array init - Split nested designated initializer (v4l2_streamparm) - Remove redundant typedef struct pattern Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
UI Previewmici: Videos are identical! View Diff Report |
Use assert/REQUIRE for system calls where failure matters,
if(){} for destructor/signal handler cleanup where it doesn't.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
FrogAi
pushed a commit
to FrogAi/FrogPilot
that referenced
this pull request
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.