Added EX-L subsection for the existing 2019 Pilot#489
Added EX-L subsection for the existing 2019 Pilot#489rbiasini merged 3 commits intocommaai:develfrom
Conversation
Verified working with @hitmantw25 12/20... and again 12/27 (VG w/ "Josh").
|
What's weird is that PR #401 is also supposed to fix the EX-L trim, but these fingerprints are different. |
|
Definitely odd, especially because i generated this from a several-minute cabana rlog. I would suggest merging the 2019 EX-L fingerprints (If necessary, maybe this new fingerprint includes all of the additional ID's from last merge) and bringing back the old non 2019 base fingerprint. Previous pre-2019 fingerprint below: |
|
I added a change suggestion for @ErichMoraga to merge, this current PR includes all additional ids from previous merge plus 339: 7 (are there two engines, maybe?. With the suggested change first fingerprint should match pilots before 2019 and second fingerprint should match our known 2019 pilots. |
|
Looks like the EX-L has AWD as an option, maybe that's where the difference is coming from? |
|
I don't expect the trim itself to strictly identify the fingerprint. Potentially, any extra option (seat heaters etc..) could modify msgs on CAN. @ErichMoraga @energee what do you guys recommend? |
|
I'm fine w/ @energee's recommendation if we can confirm the proposed fingerprint works for @hitmantw25, "Josh", and whoever @energee worked with on his initial PR. |
rbiasini
left a comment
There was a problem hiding this comment.
Cool, I'll do few tests and then I'll merge. Tnx guys
@energee wants to revert a change he made in a previous PR. Co-Authored-By: ErichMoraga <33645296+ErichMoraga@users.noreply.github.com>
* Added EX-L subsection for the existing 2019 Pilot Verified working with @hitmantw25 12/20... and again 12/27 (VG w/ "Josh"). * Update selfdrive/car/honda/values.py @energee wants to revert a change he made in a previous PR. Co-Authored-By: ErichMoraga <33645296+ErichMoraga@users.noreply.github.com> * Removed an extra space @energee included.
Allows us to automatically keep our LFS in sync with comma's and also to manually perform a sync if we need to. Even able to sync the LFS from a given commit hash or a given branch. Useful for model stuff.
Verified working with @hitmantw25 12/20... and again 12/27 (VG w/ "Josh").