Skip to content

Added EX-L subsection for the existing 2019 Pilot#489

Merged
rbiasini merged 3 commits intocommaai:develfrom
ErichMoraga:patch-1
Dec 31, 2018
Merged

Added EX-L subsection for the existing 2019 Pilot#489
rbiasini merged 3 commits intocommaai:develfrom
ErichMoraga:patch-1

Conversation

@ErichMoraga
Copy link
Copy Markdown
Contributor

Verified working with @hitmantw25 12/20... and again 12/27 (VG w/ "Josh").

Verified working with @hitmantw25 12/20... and again 12/27 (VG w/ "Josh").
@vanillagorillaa
Copy link
Copy Markdown
Contributor

What's weird is that PR #401 is also supposed to fix the EX-L trim, but these fingerprints are different.

@energee
Copy link
Copy Markdown
Contributor

energee commented Dec 27, 2018

Definitely odd, especially because i generated this from a several-minute cabana rlog. I would suggest merging the 2019 EX-L fingerprints (If necessary, maybe this new fingerprint includes all of the additional ID's from last merge) and bringing back the old non 2019 base fingerprint.

Previous pre-2019 fingerprint below:

57: 3, 145: 8, 228: 5, 308: 5, 316: 8, 334: 8, 342: 6, 344: 8, 379: 8, 380: 8, 399: 7, 411: 5, 419: 8, 420: 8, 422: 8, 425: 8, 426: 8, 427: 3, 432: 7, 463: 8, 464: 8, 476: 4, 490: 8, 506: 8, 538: 3, 542: 7, 545: 5, 546: 3, 597: 8, 660: 8, 773: 7, 777: 8, 780: 8, 795: 8, 800: 8, 804: 8, 808: 8, 817: 4, 819: 7, 821: 5, 825: 4, 829: 5, 837: 5, 856: 7, 871: 8, 881: 8, 882: 2, 884: 7, 891: 8, 892: 8, 923: 2, 927: 8, 929: 8, 983: 8, 985: 3, 1029: 8, 1052: 8, 1064: 7, 1088: 8, 1089: 8, 1092: 1, 1108: 8, 1110: 8, 1125: 8, 1296: 8, 1424: 5, 1445: 8, 1600: 5, 1601: 8, 1612: 5, 1613: 5, 1614: 5, 1615: 8, 1616: 5, 1617: 8, 1618: 5, 1623: 5, 1668: 5``` 

Comment thread selfdrive/car/honda/values.py Outdated
@energee
Copy link
Copy Markdown
Contributor

energee commented Dec 27, 2018

I added a change suggestion for @ErichMoraga to merge, this current PR includes all additional ids from previous merge plus 339: 7 (are there two engines, maybe?. With the suggested change first fingerprint should match pilots before 2019 and second fingerprint should match our known 2019 pilots.

@vanillagorillaa
Copy link
Copy Markdown
Contributor

Looks like the EX-L has AWD as an option, maybe that's where the difference is coming from?

@rbiasini
Copy link
Copy Markdown
Contributor

I don't expect the trim itself to strictly identify the fingerprint. Potentially, any extra option (seat heaters etc..) could modify msgs on CAN.

@ErichMoraga @energee what do you guys recommend?

@ErichMoraga
Copy link
Copy Markdown
Contributor Author

I'm fine w/ @energee's recommendation if we can confirm the proposed fingerprint works for @hitmantw25, "Josh", and whoever @energee worked with on his initial PR.

Copy link
Copy Markdown
Contributor

@rbiasini rbiasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I'll do few tests and then I'll merge. Tnx guys

energee and others added 2 commits December 30, 2018 20:07
@energee wants to revert a change he made in a previous PR.

Co-Authored-By: ErichMoraga <33645296+ErichMoraga@users.noreply.github.com>
@rbiasini rbiasini merged commit 0fded2c into commaai:devel Dec 31, 2018
@ErichMoraga ErichMoraga deleted the patch-1 branch January 5, 2019 14:15
sshane referenced this pull request in sshane/openpilot Dec 2, 2019
ghost pushed a commit to dragonpilot/dragonpilot that referenced this pull request Apr 7, 2020
*  Added EX-L subsection for the existing 2019 Pilot

Verified working with @hitmantw25 12/20... and again 12/27 (VG w/ "Josh").

* Update selfdrive/car/honda/values.py

@energee wants to revert a change he made in a previous PR.

Co-Authored-By: ErichMoraga <33645296+ErichMoraga@users.noreply.github.com>

* Removed an extra space @energee included.
ccdunder pushed a commit to ccdunder/openpilot that referenced this pull request Dec 28, 2024
Allows us to automatically keep our LFS in sync with comma's and also to manually perform a sync if we need to. Even able to sync the LFS from a given commit hash or a given branch. Useful for model stuff.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants